Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Reshard] Reshard from replicate to partial #56833

Merged
merged 1 commit into from
Sep 4, 2023
Merged

[Reshard] Reshard from replicate to partial #56833

merged 1 commit into from
Sep 4, 2023

Conversation

LiYuRio
Copy link
Contributor

@LiYuRio LiYuRio commented Aug 31, 2023 •
edited
Loading

PR types

New features

PR changes

Others

Description

Pcard-73145

支持一维process_mesh下，replicate到partial的状态转换。

  • 只支持输出状态为partial_sum，主rank保留所有数据，其他rank置为0。
  • 将reshard接入DistTensor.numpy方法中，在python端调用tensor.numpy即进行reshard，返回replicate状态的全量数据。

TODO：

  • 修复在正确判断语义下，spmd_rule_test单测报错的问题；
  • 增强replicate到partial的检查，强检查支持partial_sum状态

@paddle-bot
Copy link

paddle-bot bot commented Aug 31, 2023

你的PR提交成功，感谢你对开源项目的贡献!
请关注后续CI自动化测试结果，详情请参考Paddle-CI手册。
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@LiYuRio LiYuRio force-pushed the dev_reshard branch 2 times, most recently from 316e7a6 to c281f5c Compare August 31, 2023 08:29
chenwhql
chenwhql approved these changes Sep 1, 2023
View reviewed changes
Copy link
Contributor

@chenwhql chenwhql left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

ForFishes
ForFishes approved these changes Sep 4, 2023
View reviewed changes
Copy link
Member

@ForFishes ForFishes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@LiYuRio LiYuRio merged commit a28e6f6 into PaddlePaddle:develop Sep 4, 2023
LiYuRio added a commit to LiYuRio/Paddle that referenced this pull request Sep 4, 2023
@LiYuRio
reshard r to p (PaddlePaddle#56833)
0043c5a
BeingGod pushed a commit to BeingGod/Paddle that referenced this pull request Sep 9, 2023
@LiYuRio @BeingGod
reshard r to p (PaddlePaddle#56833)
e16ea8e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chenwhql chenwhql chenwhql approved these changes

@ForFishes ForFishes ForFishes approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@LiYuRio @ForFishes @chenwhql