Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix bilinear_tensor_product_op in debug mode. #5703

Merged
merged 2 commits into from
Nov 16, 2017
Merged

Fix bilinear_tensor_product_op in debug mode. #5703

merged 2 commits into from
Nov 16, 2017

Conversation

qingqing01
Copy link
Contributor

Fix #5695

peterzhang2029
peterzhang2029 reviewed Nov 16, 2017
View reviewed changes
paddle/operators/bilinear_tensor_product_op.h Outdated
@@ -63,6 +63,7 @@ class BilinearTensorProductKernel : public framework::OpKernel<T> {
math::gemm<Place, T>(ctx.device_context(), CblasNoTrans, CblasNoTrans,
batch_size, y_dim, x_dim, 1, x->data<T>(),
weight_mat.data<T>(), 0, left_mul.data<T>());
Eigen::array<int, 2> shape({{static_cast<int>(out->dims()[0]), 1}});
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这里的shape用在哪里呢？

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

去掉了~

@peterzhang2029
Copy link
Contributor

LGTM, Thanks!

@peterzhang2029 peterzhang2029 merged commit 55c2c73 into PaddlePaddle:develop Nov 16, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peterzhang2029 peterzhang2029 peterzhang2029 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@qingqing01 @peterzhang2029