Compilation optimization for reduce #57082
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
你的PR提交成功，感谢你对开源项目的贡献! |
|
更新下最新的develop |
Xreki
reviewed
Sep 22, 2023
| phi::SumKernel<T, Context>(ctx, | ||
| *input_tensor, | ||
| reduce_dims_vec, | ||
| input_tensor->dtype(), |
| @@ -27,8 +27,7 @@ void MaxRawKernel(const Context& dev_ctx, | |||
| DenseTensor* out) { | |||
| reduce_all = recompute_reduce_all(x, dims, reduce_all); | |||
| auto out_dtype = x.dtype(); | |||
| phi::Reduce<T, kps::MaxFunctor, kps::IdentityFunctor>( | |||
| dev_ctx, x, reduce_all, dims.GetData(), keep_dim, out_dtype, out); | |||
| phi::MaxKernel<T, Context>(dev_ctx, x, dims, keep_dim, out); | |||
There was a problem hiding this comment.
MaxRawKernel比MaxKernel多一个参数，应在MaxKernel里面调MaxRawKernel比较合理
AnnaTrainingG
approved these changes
Sep 27, 2023
Frida-a
pushed a commit
to Frida-a/Paddle
that referenced
this pull request
Oct 14, 2023
jiahy0825
pushed a commit
to jiahy0825/Paddle
that referenced
this pull request
Oct 16, 2023
danleifeng
pushed a commit
to danleifeng/Paddle
that referenced
this pull request
Nov 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Others
PR changes
Others
Description
kernel编译体积优化--kernel类型：reduce
Pcard-70459