Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[clang-tidy] NO.8 enable cppcoreguidelines-narrowing-conversions. step:4 #57114

Merged
merged 8 commits into from
Sep 15, 2023
Merged

[clang-tidy] NO.8 enable cppcoreguidelines-narrowing-conversions. step:4 #57114

merged 8 commits into from
Sep 15, 2023

Conversation

gouzil
Copy link
Member

@gouzil gouzil commented Sep 8, 2023 •
edited
Loading

@paddle-bot
Copy link

paddle-bot bot commented Sep 8, 2023

你的PR提交成功，感谢你对开源项目的贡献!
请关注后续CI自动化测试结果，详情请参考Paddle-CI手册。
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@paddle-bot paddle-bot bot added the contributor External developers label Sep 8, 2023
@gouzil gouzil changed the title [clang-tidy] NO.8 enable cppcoreguidelines-narrowing-conversions. step:4 [clang-tidy] NO.8 enable cppcoreguidelines-narrowing-conversions. step:4 Sep 8, 2023
@luotao1 luotao1 added the HappyOpenSource Pro 进阶版快乐开源活动，更具挑战性的任务 label Sep 8, 2023
@luotao1
Copy link
Contributor

luotao1 commented Sep 11, 2023

需要解决下冲突

@gouzil
Merge branch 'develop' of github.com:gouzil/Paddle into c_t_narrowing…
bae1fa9 
…_conversions_sp4

# Conflicts:
#	paddle/fluid/pir/phi_kernel_adaptor/phi_kernel_util.cc
@gouzil
fix
0521db6
@gouzil
fix
3c3aad7
@gouzil
Copy link
Member Author

gouzil commented Sep 12, 2023

需要解决下冲突

Done

@luotao1
Copy link
Contributor

luotao1 commented Sep 13, 2023

又冲突了

@gouzil
Merge branch 'develop' of github.com:gouzil/Paddle into c_t_narrowing…
71232b9 
…_conversions_sp4

# Conflicts:
#	paddle/fluid/pybind/eager_functions.cc
@gouzil
fix
f35a28c
@gouzil
Copy link
Member Author

gouzil commented Sep 13, 2023

又冲突了

Done

@luotao1 luotao1 merged commit 2ad4d49 into PaddlePaddle:develop Sep 15, 2023
@gouzil gouzil deleted the c_t_narrowing_conversions_sp4 branch September 24, 2023 14:29
danleifeng pushed a commit to danleifeng/Paddle that referenced this pull request Nov 14, 2023
@gouzil
[clang-tidy] NO.8 enable cppcoreguidelines-narrowing-conversions. s…
8d06066 
…tep:4 (PaddlePaddle#57114)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zhangbo9674 zhangbo9674 zhangbo9674 approved these changes

Assignees

@luotao1 luotao1

@GreatV GreatV

@zhangbo9674 zhangbo9674

Labels
contributor External developers HappyOpenSource Pro 进阶版快乐开源活动，更具挑战性的任务
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@gouzil @luotao1 @zhangbo9674 @GreatV