add dot_prod_layer #5724
Merged
add dot_prod_layer #5724
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lcy-seso
reviewed
Nov 17, 2017
| config.layerConfig.add_inputs(); | ||
|
|
||
| for (auto useGpu : {false, true}) { | ||
| testLayerGrad(config, "dot_prod", 100, false, useGpu); |
There was a problem hiding this comment.
这里的batch size 改小一些，不需要用这么大的batch size 跑单测。
| @@ -4141,6 +4143,45 @@ def maxid_layer(input, name=None, layer_attr=None): | |||
|
|
|||
|
|
|||
| @wrap_name_default() | |||
| def dot_prod_layer(input1, input2, name=None, layer_attr=None): | |||
lcy-seso
reviewed
Nov 17, 2017
| .. autoclass:: paddle.v2.layer.dot_prod | ||
| :noindex: | ||
|
|
||
| out_prod |
| namespace paddle { | ||
|
|
||
| /** | ||
| * @brief A layer for computing the dot product of two vectors |
| Layer::init(layerMap, parameterMap); | ||
|
|
||
| CHECK_EQ(inputLayers_.size(), 2U); | ||
| CHECK_EQ(1, getSize()) << "Dimension mismatch"; |
There was a problem hiding this comment.
- 1UL
- The output dimensionality of this layer should be fixed to 1.
| def __init__(self, name, inputs, device=None): | ||
| super(DotProdLayer, self).__init__( | ||
| name, 'dot_prod', 0, inputs, device=device) | ||
| config_assert(len(inputs) == 2, 'DotProdLayer must have 2 inputs') |
lcy-seso
reviewed
Nov 17, 2017
| def __init__(self, name, inputs, device=None): | ||
| super(DotProdLayer, self).__init__( | ||
| name, 'dot_prod', 0, inputs, device=device) | ||
| config_assert(len(inputs) == 2, 'DotProdLayer must have 2 inputs.') |
There was a problem hiding this comment.
这里加一个检测，检查一下两个输入的维度必须相同。
self.get_input_layer(0).size == self.get_input_layer(1).size| MatrixPtr inV1 = getInputValue(1); | ||
|
|
||
| size_t batchSize = inV0->getHeight(); | ||
| CHECK_EQ(inV1->getHeight(), batchSize); |
There was a problem hiding this comment.
这里检查一下 inv0 和 inv1 的宽度必须相同。
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #5496