-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Compile optimize frobenius_norm op and trace op #57327
Compile optimize frobenius_norm op and trace op #57327
Conversation
你的PR提交成功,感谢你对开源项目的贡献! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
funcs::ReduceKernel<T, T, kps::AddFunctor, kps::IdentityFunctor<T>>( | ||
ctx, diag, out, kps::IdentityFunctor<T>(), reduce_dims); | ||
phi::SumKernel<T, Context>( | ||
ctx, diag, reduce_dims, diag.dtype(), false, out); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
准确来说,第4个参数是out_dtype
,应该传输出out
的dtype。第5个参数。。。好像实际实现没用到。。。
* add sqrtkerenl * update * add trace_kernel * update --------- Co-authored-by: niuliling123 <sdust_niull@163.com>
* add sqrtkerenl * update * add trace_kernel * update --------- Co-authored-by: niuliling123 <sdust_niull@163.com>
PR types
Others
PR changes
Others
Description
Pcard-70459
reduce type compile optimize