Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Semi-Auto] Adapt layer_norm spmd rule to phi #57374

Merged
merged 4 commits into from
Sep 22, 2023

Conversation

pkuzyc
Copy link
Contributor

@pkuzyc pkuzyc commented Sep 15, 2023

PR types

Function optimization

PR changes

Others

Description

Pcard-73145

  1. Adapt the layer_norm spmd rule to phi.
  2. Rephrase the infer_forward function to make it more consistent with infer_backward.

@paddle-bot
Copy link

paddle-bot bot commented Sep 15, 2023

你的PR提交成功,感谢你对开源项目的贡献!
请关注后续CI自动化测试结果,详情请参考Paddle-CI手册
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

Copy link
Contributor

@JZ-LIANG JZ-LIANG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

[self.x_spec, self.scale_spec, self.bias_spec],
[self.out_spec, self.mean_spec, self.var_spec],
self.attrs,
self.x_spec,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add LN python test to Cmake in Next PR

@JZ-LIANG JZ-LIANG merged commit bcc3305 into PaddlePaddle:develop Sep 22, 2023
Frida-a pushed a commit to Frida-a/Paddle that referenced this pull request Oct 14, 2023
* adapt layer_norm spmd rule to phi

* modify api in unit test

* bug fix

* fix bug in cpp unit test
jiahy0825 pushed a commit to jiahy0825/Paddle that referenced this pull request Oct 16, 2023
* adapt layer_norm spmd rule to phi

* modify api in unit test

* bug fix

* fix bug in cpp unit test
danleifeng pushed a commit to danleifeng/Paddle that referenced this pull request Nov 14, 2023
* adapt layer_norm spmd rule to phi

* modify api in unit test

* bug fix

* fix bug in cpp unit test
@pkuzyc pkuzyc deleted the adapt_phi/layer_norm branch February 6, 2024 02:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants