[NewComm] No.10 compatiable upgrade for distributed_fused_lamb op #57424
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
单测目前存在问题， |
|
换一个初始化方式。如果使用新通信库，使用 |
…tributed_fused_lamb
| @@ -270,7 +270,10 @@ def setUpClass(cls): | |||
| paddle.enable_static() | |||
| paddle.set_flags({'FLAGS_cudnn_deterministic': True}) | |||
| _clip_by_global_norm_using_mp_type(True) | |||
| fleet.init(role_maker=get_role_maker()) | |||
| if os.environ.get("FLAGS_dynamic_static_unified_comm") == "1": | |||
| fleet.init(role_maker=get_role_maker()) | |||
There was a problem hiding this comment.
判断写反了吧，设置FLAGS_dynamic_static_unified_comm = 1 的时候，应该用paddle.distributed.collective._init_parallel_env("nccl")的方式初始化。
| @@ -228,5 +231,19 @@ void NCCLCommContext::GroupStart() { | |||
| } | |||
| void NCCLCommContext::GroupEnd() { NCCL_CHECK(phi::dynload::ncclGroupEnd()); } | |||
|
|
|||
| #if NCCL_VERSION_CODE >= 21100 | |||
There was a problem hiding this comment.
这里加一点注释信息吧，解释一下这个函数是干啥的，直接看名字很难弄懂功能。可以附上链接：https://docs.nvidia.com/deeplearning/nccl/user-guide/docs/api/ops.html，把里面Op功能的解释，整点到注释里。
BeingGod
force-pushed
the
comm_distributed_fused_lamb
branch
from
4f2badd
to
8a29c88
Compare
luotao1
approved these changes
Sep 21, 2023
iosmers
pushed a commit
to iosmers/Paddle
that referenced
this pull request
Sep 21, 2023
…ddlePaddle#57424) * [NewComm] No.10 compatiable upgrade for distributed_fused_lamb op * fix
Frida-a
pushed a commit
to Frida-a/Paddle
that referenced
this pull request
Oct 14, 2023
…ddlePaddle#57424) * [NewComm] No.10 compatiable upgrade for distributed_fused_lamb op * fix
jiahy0825
pushed a commit
to jiahy0825/Paddle
that referenced
this pull request
Oct 16, 2023
…ddlePaddle#57424) * [NewComm] No.10 compatiable upgrade for distributed_fused_lamb op * fix
danleifeng
pushed a commit
to danleifeng/Paddle
that referenced
this pull request
Nov 14, 2023
…ddlePaddle#57424) * [NewComm] No.10 compatiable upgrade for distributed_fused_lamb op * fix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Others
PR changes
APIs
Description
compatiable upgrade for
distributed_fused_lambop#57102