Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix pool max with index.(Mask type should be int, not float) #5749

Merged
merged 3 commits into from
Nov 20, 2017
Merged

Fix pool max with index.(Mask type should be int, not float) #5749

merged 3 commits into from
Nov 20, 2017

Conversation

chengduoZH
Copy link
Contributor

@chengduoZH chengduoZH commented Nov 17, 2017 •
edited
Loading

fix #5750

kexinzhao
kexinzhao reviewed Nov 17, 2017
View reviewed changes
python/paddle/v2/fluid/tests/test_pool_max_op.py Outdated
class TestCase7(TestMaxPoolWithIndex_Op):
def init_test_case(self):

class TestCase5(TestMaxPoolWithIndex_Op):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should it be TestCase5(TestCase4) ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch. I have fixed it.

kexinzhao
kexinzhao previously approved these changes Nov 19, 2017
View reviewed changes
Copy link
Contributor

@kexinzhao kexinzhao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@chengduoZH chengduoZH merged commit faea248 into PaddlePaddle:develop Nov 20, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qingqing01 qingqing01 qingqing01 approved these changes

@kexinzhao kexinzhao kexinzhao left review comments

@hedaoyuan hedaoyuan Awaiting requested review from hedaoyuan

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

The Mask as input of max_pool_with_index_op should be int type, not float32.
3 participants
@chengduoZH @qingqing01 @kexinzhao