Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NewComm] Set new communication library as default. #57768

Merged

Conversation

GhostScreaming
Copy link
Contributor

@GhostScreaming GhostScreaming commented Sep 26, 2023

PR types

Others

PR changes

Others

Description

Pcard-70448

Set Flags_dynamic_static_unified_comm true in default. New communication library will be used defaultly.

New communication library will be used defaultly.
@paddle-bot
Copy link

paddle-bot bot commented Sep 26, 2023

你的PR提交成功,感谢你对开源项目的贡献!
请关注后续CI自动化测试结果,详情请参考Paddle-CI手册
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@paddle-ci-bot
Copy link

paddle-ci-bot bot commented Oct 4, 2023

Sorry to inform you that 515d9fe's CIs have passed for more than 7 days. To prevent PR conflicts, you need to re-run all CIs manually.

Copy link

@hitywt hitywt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@@ -17,4 +17,5 @@
set -e
# use default values
# FIXME: random fails on Unknown command lines -c (or -m).
export FLAGS_dynamic_stat:ic_unified_comm=0
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这个拼错了吧

@GhostScreaming GhostScreaming merged commit 3335978 into PaddlePaddle:develop Oct 11, 2023
28 checks passed
Frida-a pushed a commit to Frida-a/Paddle that referenced this pull request Oct 14, 2023
* [NewComm] Set Flags_dynamic_static_unified_comm `True` in default.
New communication library will be used defaultly.

* Polish code.

* Fix problems of distributed testcases using new comm lib.

* Fix problems of testcases using new comm lib in default.

* Fix failed testcase.

* Fix falied testcases.
jiahy0825 pushed a commit to jiahy0825/Paddle that referenced this pull request Oct 16, 2023
* [NewComm] Set Flags_dynamic_static_unified_comm `True` in default.
New communication library will be used defaultly.

* Polish code.

* Fix problems of distributed testcases using new comm lib.

* Fix problems of testcases using new comm lib in default.

* Fix failed testcase.

* Fix falied testcases.
danleifeng pushed a commit to danleifeng/Paddle that referenced this pull request Nov 14, 2023
* [NewComm] Set Flags_dynamic_static_unified_comm `True` in default.
New communication library will be used defaultly.

* Polish code.

* Fix problems of distributed testcases using new comm lib.

* Fix problems of testcases using new comm lib in default.

* Fix failed testcase.

* Fix falied testcases.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants