[Cherry-pick] Add config for broadcast data in model parallel #57843
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
你的PR提交成功，感谢你对开源项目的贡献! |
sneaxiy
previously approved these changes
Sep 28, 2023
gongweibao
reviewed
Oct 2, 2023
| @@ -56,6 +56,8 @@ message MpConfig { | |||
| optional bool sync_grad= 2 [ default = false ]; | |||
| optional bool sync_moment= 3 [ default = false ]; | |||
| optional string sync_mode= 4 [ default = 'broadcast' ]; | |||
| // Broadcast mp input data | |||
| optional bool need_broadcast_data=8 [default = true]; | |||
There was a problem hiding this comment.
在mp的cofig里面，应该不需要再补“for_tp”
sneaxiy
approved these changes
Oct 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
New features
PR changes
Others
Description
[Cherry-pick] Add config for broadcast data in model parallel
Pcard-70448
support remove broadcast data in this pr:
#57567