[Hackathon 5th No.49][pir] add some method property - Part 2 #58042
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
你的PR提交成功，感谢你对开源项目的贡献! |
|
hi田川，这里是否方便整理一个这样的列表：表里列出动态图Tensor、老IR下Varialbe、新IR下OpResult上patch的方法有哪些。这样我们可以直观的看到当前对齐的一个进度情况，可以整理一下发一个issue里~ |
Aurelius84
reviewed
Oct 16, 2023
python/paddle/pir/math_op_patch.py
Outdated
| ) | ||
|
|
||
| @property | ||
| def _ndim_(self): |
There was a problem hiding this comment.
这里最后为什么还有一个下划线，_item只有前下划线。可以统一一下，比如：
- 对于builtin 方法的映射，若有，可以「单下划线+名字+单下划线」，如 xx
- 对于 property 属性的映射，若有，可以「单下划线+名字」，如 _x
- 对于 方法的映射，若有，直接「名字」即可，如x
类似如上的约定
There was a problem hiding this comment.
Done, 已同步至动态图 Tensor 和老 IR Varialbe
YuanRisheng
reviewed
Oct 16, 2023
python/paddle/pir/math_op_patch.py
Outdated
| >>> paddle.enable_static() | ||
|
|
||
| >>> # create a static OpResult | ||
| >>> with paddle.pir_utils.IrGuard(): |
There was a problem hiding this comment.
这里新加的接口如果和之前是一致的，这里可以去掉with paddle.pir_utils.IrGuard()，后期pir推广默认不需要这个guard
python/paddle/pir/math_op_patch.py
Outdated
| >>> paddle.enable_static() | ||
|
|
||
| >>> # create a static OpResult | ||
| >>> with paddle.pir_utils.IrGuard(): |
python/paddle/pir/math_op_patch.py
Outdated
| >>> paddle.enable_static() | ||
|
|
||
| >>> # create a static OpResult | ||
| >>> with paddle.pir_utils.IrGuard(): |
…operty # Conflicts: # python/paddle/pir/math_op_patch.py
|
YuanRisheng
approved these changes
Oct 17, 2023
Aurelius84
approved these changes
Oct 17, 2023
tianshuo78520a
approved these changes
Oct 17, 2023
0x45f
approved these changes
Oct 17, 2023
hitywt
pushed a commit
to hitywt/Paddle
that referenced
this pull request
Oct 24, 2023
jiahy0825
pushed a commit
to jiahy0825/Paddle
that referenced
this pull request
Oct 26, 2023
This was referenced Nov 6, 2023
danleifeng
pushed a commit
to danleifeng/Paddle
that referenced
this pull request
Nov 14, 2023
This was referenced Nov 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Others
PR changes
Others
Description
添加
place(warnings)、ndimension、dim、ndim、item方法相关链接：