Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

【PIR API adaptor No.66、68、110、136】Migrate some ops into pir #58287

Merged
merged 22 commits into from
Oct 25, 2023
Merged

【PIR API adaptor No.66、68、110、136】Migrate some ops into pir #58287

merged 22 commits into from
Oct 25, 2023

Conversation

zrr1999
Copy link
Member

@zrr1999 zrr1999 commented Oct 20, 2023 •
edited by 0x45f
Loading

PR types

Others

PR changes

APIs

Description

PIR API 推全升级
将如下算子迁移升级至 pir，并更新单测

  • real/imag(2/4)：check grad会报错，没有打开check grad
  • logit(8/8)
  • isnan：没有对应的单测文件
  • expand_as (5/5)
  • flip(6/6)
  • equal_all (4/4)
  • logic_and(0/1)：添加test_with_pir_api对应单测case报错，应该需要适配其他几个logic_xx op后一起打开对应单测
  • nonzero(2/2)

test_logical_op.py 给 run_static 添加 test_with_pir_api 时遇到报错

TypeError: Cannot interpret '<DataType.BOOL: 1>' as a data type

@paddle-bot
Copy link

paddle-bot bot commented Oct 20, 2023

你的PR提交成功，感谢你对开源项目的贡献!
请关注后续CI自动化测试结果，详情请参考Paddle-CI手册。
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@paddle-bot paddle-bot bot added the contributor External developers label Oct 20, 2023
@paddle-bot
Copy link

paddle-bot bot commented Oct 20, 2023 •
edited
Loading

✅ This PR's description meets the template requirements!
Please wait for other CI results.

@zrr1999 zrr1999 changed the title [PIR] Migrate flip, expand_as, broadcast_to, real, imag into pir [PIR] Migrate some ops into pir Oct 23, 2023
@zrr1999 zrr1999 requested a review from 0x45f October 23, 2023 06:05
@MarioLulab MarioLulab mentioned this pull request Oct 23, 2023
Closed
@0x45f
Copy link
Contributor

0x45f commented Oct 23, 2023 •
edited
Loading

几个单测的问题：

  1. test_real_imag_op.py：test_check_grad目前反向有问题，内部的同学会跟进，暂时先关闭了
  2. test_full_op.py：新IR下注意单测内需要用新的Program，我已经提PR做了修改
  3. test_broadcast_to_op.py：broadcast_to对应的单测是test_broadcast_to_op.py这个单测文件，而不是expand那个单测文件。但是目前test_broadcast_to_op.py中有的case新IR机制支持上还有问题，所以先不适配broadcast_to这个api了，内部先将不支持的case支持。

@0x45f
Copy link
Contributor

0x45f commented Oct 23, 2023 •
edited
Loading

荣瑞，辛苦在PR描述中贴一下，这PR适配了哪几个API，每个API对应的单测文件中有几个测试case中，在新IR下打开了几个case，如果有case没有打开的话也写一下没有打开的原因~类似 #58067 中的PR描述样例
我看PR中似乎没有打开logical_and的单测

@zrr1999
Copy link
Member Author

zrr1999 commented Oct 23, 2023

荣瑞，辛苦在PR描述中贴一下，这PR适配了哪几个API，每个API对应的单测文件中有几个测试case中，在新IR下打开了几个case，如果有case没有打开的话也写一下没有打开的原因~类似 #58067 中的PR描述样例 我看PR中似乎没有打开logical_and的单测

好的，已经修改完毕，现在应该只剩下isnan和logical_and没有添加单测，

Aurelius84
Aurelius84 approved these changes Oct 25, 2023
View reviewed changes
Copy link
Contributor

@Aurelius84 Aurelius84 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work!

@0x45f 0x45f merged commit 7adb2f0 into PaddlePaddle:develop Oct 25, 2023
28 checks passed
@Ligoml Ligoml changed the title [PIR] Migrate some ops into pir 【PIR API adaptor No.66、68、110、136】Migrate some ops into pir Oct 25, 2023
@zrr1999 zrr1999 mentioned this pull request Oct 25, 2023
Closed
23 tasks
danleifeng pushed a commit to danleifeng/Paddle that referenced this pull request Nov 14, 2023
@zrr1999
[PIR] Migrate some ops into pir (PaddlePaddle#58287)
409deaf
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0x45f 0x45f 0x45f approved these changes

@Aurelius84 Aurelius84 Aurelius84 approved these changes

Assignees

@0x45f 0x45f

@zrr1999 zrr1999

Labels
contributor External developers
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zrr1999 @0x45f @Aurelius84