Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

【PIR API adaptor No.48、49】 Migrate cummax/min into pir #58629

Merged
merged 4 commits into from
Nov 6, 2023
Merged

【PIR API adaptor No.48、49】 Migrate cummax/min into pir #58629

merged 4 commits into from
Nov 6, 2023

Conversation

DrRyanHuang
Copy link
Member

@DrRyanHuang DrRyanHuang commented Nov 2, 2023 •
edited
Loading

PR types

Others

PR changes

Others

Description

PIR API 推全升级

cummin 单测覆盖率：11/11
cummax 单测覆盖率：11/11

@paddle-bot Paddle-bot
Copy link

paddle-bot bot commented Nov 2, 2023

你的PR提交成功，感谢你对开源项目的贡献!
请关注后续CI自动化测试结果，详情请参考Paddle-CI手册。
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@paddle-bot paddle-bot bot added the contributor External developers label Nov 2, 2023
@paddle-bot Paddle-bot
Copy link

paddle-bot bot commented Nov 2, 2023 •
edited
Loading

✅ This PR's description meets the template requirements!
Please wait for other CI results.

@DrRyanHuang DrRyanHuang changed the title add cummax/min test 【PIR API adaptor No.48、49】 Migrate cummax/min into pir Nov 2, 2023
@luotao1 luotao1 mentioned this pull request Nov 3, 2023
Closed
@YuanRisheng
Copy link
Contributor

这个错误的原因是在底层C++算子的定义中，使用了int类型的参数，在新IR下需要使用DataType类型，可以参考这个PR：https://github.com/PaddlePaddle/Paddle/pull/57909，把C++端的Kernel以及yaml文件修改一下应该就可以解决

@paddle-bot paddle-bot bot removed the contributor External developers label Nov 3, 2023
@DrRyanHuang
Copy link
Member Author

DrRyanHuang commented Nov 4, 2023 •
edited
Loading

@YuanRisheng 打扰了，PR-CI-Static-Check 和 PR-CI-APPROVAL 可以 approve 吗，PR-CI-Model-benchmark 可以豁免吗，rerun好几次了😟😟

@DrRyanHuang DrRyanHuang changed the title 【PIR API adaptor No.48、49】 Migrate cummax/min into pir 【PIR api adaptor No.48、49】 Migrate cummax/min into pir Nov 4, 2023
MarioLulab
MarioLulab approved these changes Nov 6, 2023
View reviewed changes
Copy link
Contributor

@MarioLulab MarioLulab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@0x45f 0x45f merged commit ee36554 into PaddlePaddle:develop Nov 6, 2023
28 checks passed
@DrRyanHuang DrRyanHuang changed the title 【PIR api adaptor No.48、49】 Migrate cummax/min into pir 【PIR API adaptor No.48、49】 Migrate cummax/min into pir Nov 6, 2023
@DrRyanHuang DrRyanHuang deleted the 4849 branch November 6, 2023 07:03
@DrRyanHuang DrRyanHuang mentioned this pull request Nov 7, 2023
Closed
22 tasks
zeroRains pushed a commit to zeroRains/Paddle that referenced this pull request Nov 8, 2023
@DrRyanHuang @zeroRains
【PIR api adaptor No.48、49】 Migrate cummax/min into pir (PaddlePaddle#…
c344b56 
…58629)
danleifeng pushed a commit to danleifeng/Paddle that referenced this pull request Nov 14, 2023
@DrRyanHuang
【PIR api adaptor No.48、49】 Migrate cummax/min into pir (PaddlePaddle#…
a00e7da 
…58629)
SecretXV pushed a commit to SecretXV/Paddle that referenced this pull request Nov 28, 2023
@DrRyanHuang @SecretXV
【PIR api adaptor No.48、49】 Migrate cummax/min into pir (PaddlePaddle#…
d22f205 
…58629)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MarioLulab MarioLulab MarioLulab approved these changes

@0x45f 0x45f 0x45f approved these changes

@zyfncg zyfncg zyfncg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@DrRyanHuang @YuanRisheng @zyfncg @0x45f @MarioLulab