No.18 paddle.nn.GLU易用性提升 #58632
Merged
No.18 paddle.nn.GLU易用性提升 #58632
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
你的PR提交成功，感谢你对开源项目的贡献! |
|
❌ The PR is not created using PR's template. You can refer to this Demo. |
Closed
|
对应的中文文档也需要补充 |
|
已经添加中文文档 |
|
大部分CI已过，能否麻烦老师review @zxcd |
… nnglu resolve conflict
zxcd
reviewed
Nov 7, 2023
| @@ -0,0 +1,76 @@ | |||
| # Copyright (c) 2020 PaddlePaddle Authors. All Rights Reserved. | |||
There was a problem hiding this comment.
没必要新增一个测试文件，放到这里就可以test/legacy_test/test_glu.py
zxcd
reviewed
Nov 8, 2023
test/legacy_test/test_glu.py
Outdated
| y_var = act(x_var) | ||
| y_np = y_var.numpy() | ||
| out = glu(self.x, dim) | ||
| np.testing.assert_allclose(y_np, out, rtol=1e-05) |
danleifeng
pushed a commit
to danleifeng/Paddle
that referenced
this pull request
Nov 14, 2023
* support paddle.nn.GLU as a layer * add extra_repr ut * add test for type * update doc * update test, merge two test file * delete atol
SecretXV
pushed a commit
to SecretXV/Paddle
that referenced
this pull request
Nov 28, 2023
* support paddle.nn.GLU as a layer * add extra_repr ut * add test for type * update doc * update test, merge two test file * delete atol
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Others
PR changes
Others
Description
#55883