[dy2s] speed up PartialProgram.__call__ #58771
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
feifei-111
force-pushed
the
fall_partial_program_to_cpp
branch
from
88f7b16
to
a041eb0
Compare
feifei-111
force-pushed
the
fall_partial_program_to_cpp
branch
from
e1b2ed0
to
be0f5a9
Compare
2742195759
approved these changes
Nov 22, 2023
| autograd_meta->SetStopGradient(var_desc.StopGradient()); | ||
|
|
||
| if (var_type == paddle::framework::proto::VarType::LOD_TENSOR) { | ||
| // TODO(jiabin): Maybe support LOD later |
Comment on lines
+1902
to
+1905
| if (!autograd_meta->GetMutableGradNode()) { | ||
| autograd_meta->SetGradNode( | ||
| std::make_shared<egr::GradNodeAccumulation>(autograd_meta)); | ||
| } |
| if (PyList_Check(var_desc_list)) { | ||
| Py_ssize_t len = PyList_Size(var_desc_list); | ||
| for (Py_ssize_t i = 0; i < len; i++) { | ||
| auto var_desc = PyObjectCast<paddle::framework::VarDesc>( |
There was a problem hiding this comment.
是否可以使用 paddle::framework::VarDesc& ，防止一遍拷贝？
| auto var_desc = PyObjectCast<paddle::framework::VarDesc>( | ||
| PyList_GetItem(var_desc_list, i)); | ||
| auto var_name = var_desc.Name(); | ||
| if (out_tensor_map.find(var_name) == out_tensor_map.end()) { |
| In sot, inputs and outputs of partial program only contain tensors, so we can skip some step to speed up | ||
| """ | ||
| out_vars = self._prepare_outputs() | ||
| attrs = self._prepare_attributes() |
There was a problem hiding this comment.
如果SOT将AMP+training考虑了guard，不同的AMP状态会触发转写 / PrtialProgramLayer的重新构造，就可以将这部分加个 cache_property 中。
SecretXV
pushed a commit
to SecretXV/Paddle
that referenced
this pull request
Nov 28, 2023
* move Tensor construction to cpp * mv _remove_no_value to ASTStaticFunction * update
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Others
PR changes
Others
Description
PCard-66972