【CINN】refactor cuda query component #59096
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
你的PR提交成功，感谢你对开源项目的贡献! |
ZzSean
reviewed
Nov 17, 2023
paddle/cinn/common/dev_info_base.h
Outdated
| @@ -20,6 +20,10 @@ namespace common { | |||
| class DevInfoBase { | |||
| public: | |||
| virtual ~DevInfoBase() = default; | |||
| explicit DevInfoBase(int device = 0) : device_num_(device) {} | |||
There was a problem hiding this comment.
构造函数和析构函数位置调一下
这里传入的参数名改成device_num好一些？
ZzSean
reviewed
Nov 17, 2023
| } | ||
| template <Target::Arch arch> | ||
| DevInfoMgr<arch>::DevInfoMgr(int device_num) : device_num_(device_num) { | ||
| impl = std::make_unique<NVGPUDevInfo>(device_num) |
ZzSean
approved these changes
Nov 21, 2023
SecretXV
pushed a commit
to SecretXV/Paddle
that referenced
this pull request
Nov 28, 2023
* refactor cuda query component * fix bugs * fix review comments * fix bugs * fix cuda error * bind should be used on NVGPU device
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Others
PR changes
Others
Description
card-72718
This PR remove the ugly code for query nvgpu device info and refactor device info component for cinn