Add trace hang function #59217
Merged
Add trace hang function #59217
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ForFishes
reviewed
Nov 24, 2023
|
|
||
| int* gpu_global_ranks = nullptr; | ||
| size_t gpu_global_ranks_size = num_ranks * sizeof(int); | ||
| CUDA_CHECK(cudaMalloc(&gpu_global_ranks, gpu_global_ranks_size)); |
There was a problem hiding this comment.
为什么不走框架的显存分配，而是裸调cudaapi
这里不需要使用tensor、stream、上下文等，没有必要使用更复杂的封装实现吧
* fix trace hang * fix compile error * fix code style * tinyfix * tiny update * fix code style --------- Co-authored-by: ForFishes <1422485404@qq.com>
* fix nccl_async_trace destruct problem when train finished * update * format code style
hitywt
force-pushed
the
add_trace_hang
branch
from
316ad3a
to
8ab79e9
Compare
hitywt
force-pushed
the
add_trace_hang
branch
from
adee3bb
to
f6a4e0d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Others
PR changes
Others
Description
Pcard-70448