[Prim][PIR] silu prim sink #59306
Merged
[Prim][PIR] silu prim sink #59306
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
你的PR提交成功，感谢你对开源项目的贡献! |
| auto one = full<T>(phi::vectorize(x.dims()), 1, x_tmp.dtype()); | ||
| auto exp_temp = | ||
| exp<T>(full<T>(phi::vectorize(x.dims()), -1, x_tmp.dtype()) * x_tmp); | ||
| auto res = divide<T>(x_tmp, exp_temp + one); |
There was a problem hiding this comment.
suggest symbol overload
| auto x_tmp = x; | ||
|
|
||
| bool need_cast = | ||
| org_dtype == phi::DataType::FLOAT16 || org_dtype == phi::DataType::UINT16; |
There was a problem hiding this comment.
suggest provide common utils like is_half_dtype(...)
| auto x_tmp = x; | ||
|
|
||
| bool need_cast = | ||
| org_dtype == phi::DataType::FLOAT16 || org_dtype == phi::DataType::UINT16; |
There was a problem hiding this comment.
why unint16 instead of BFLOAT16?
SecretXV
pushed a commit
to SecretXV/Paddle
that referenced
this pull request
Nov 28, 2023
* prim silu sink * prim silu sink * add is_half_dtype function
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
New features
PR changes
Others
Description
siluop sink c++is_half_dtype()function inutils.hmean、silu、sqrt、batch_norm、softmax、layer_normoperator dtype judgment method