【Hackathon 5th No.112】move fused_gemm_epilogue to phi and add the yaml of identity_loss #59363

zeroRains · 2023-11-25T09:39:33Z

PR types

Others

PR changes

Others

Description

move fused_gemm_epilogue to phi

paddle-bot · 2023-11-25T09:39:38Z

你的PR提交成功，感谢你对开源项目的贡献!
请关注后续CI自动化测试结果，详情请参考Paddle-CI手册。
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

zeroRains · 2023-11-25T11:28:46Z

这种在编译时出现的IR错误应该怎么定位呢，希望能获得一些建议~

YuanRisheng · 2023-11-29T08:59:52Z

paddle/phi/api/yaml/op_compat.yaml

+- op: write_to_array
+  backward : fused_gemm_epilogue_grad


这里看起来写错了？

这就改，(:з」∠)

YuanRisheng · 2023-11-29T09:12:51Z

这种在编译时出现的IR错误应该怎么定位呢，希望能获得一些建议~

这个算子已经在manual_op.cc里有了手写的pir代码，无法再次通过yaml文件来生成，所以会出现如上错误，这个比较特殊，这里无法将原来的op.cc文件彻底删除，只能删除原文件的Kernel实现部分，将op定义保留，可以参考一下fused_softmax_mask这个算子。
然后接着有俩种解决方法：
1，优先考虑配置Legacy_ops.yaml文件，配置这个后会产生动态图使用的api供python端使用，需要将python端代码：_legacy_C_ops.fused_gemm_epilogue修改成_C_ops.fused_gemm_epilogue，配置这个yaml文件对静态图没影响
2，如果1方案出现了各种问题不太好处理，yaml文件就别配置了，但是这个方法无法达到算子迁移的全部目的

zeroRains · 2023-11-29T09:55:11Z

这种在编译时出现的IR错误应该怎么定位呢，希望能获得一些建议~

这种在编译时出现的IR错误应该怎么定位呢，希望能获得一些建议~

这个算子已经在manual_op.cc里有了手写的pir代码，无法再次通过yaml文件来生成，所以会出现如上错误，这个比较特殊，这里无法将原来的op.cc文件彻底删除，只能删除原文件的Kernel实现部分，将op定义保留，可以参考一下fused_softmax_mask这个算子。然后接着有俩种解决方法： 1，优先考虑配置Legacy_ops.yaml文件，配置这个后会产生动态图使用的api供python端使用，需要将python端代码：_legacy_C_ops.fused_gemm_epilogue修改成_C_ops.fused_gemm_epilogue，配置这个yaml文件对静态图没影响 2，如果1方案出现了各种问题不太好处理，yaml文件就别配置了，但是这个方法无法达到算子迁移的全部目的

谢谢老师，我学习一下~

YuanRisheng · 2023-12-04T07:22:38Z

paddle/fluid/operators/fused/fused_gemm_epilogue_op.cc

+    op->SetInput(framework::GradVarName("Out"), this->OutputGrad("Out"));

-    op->SetOutput("DX", this->InputGrad("X"));
-    op->SetOutput("DY", this->InputGrad("Y"));
-    op->SetOutput("DBias", this->InputGrad("Bias"));
+    op->SetOutput(framework::GradVarName("X"), this->InputGrad("X"));
+    op->SetOutput(framework::GradVarName("Y"), this->InputGrad("Y"));
+    op->SetOutput(framework::GradVarName("Bias"), this->InputGrad("Bias"));


这里随意修改Op定义会有问题，因为在op定义后，很多其他组件可能就默认使用定义好的名字，这里修改后会造成命名对不上，建议恢复原状

YuanRisheng · 2023-12-04T07:23:17Z

paddle/fluid/operators/fused/fused_gemm_epilogue_op.cc

 REGISTER_OPERATOR(fused_gemm_epilogue_grad,
                  ops::FusedGemmEpilogueGradOp,
-                  ops::FusedGemmEpilogueGradOpMaker);
+                  FusedGemmEpilogueGradInferShapeFunctor);


这里可以不删除ops::FusedGemmEpilogueGradOpMaker吗

… 112_fused

zeroRains · 2023-12-16T08:54:53Z

麻烦老师帮忙看一下这个是什么attribute type，我看GpuPS和Kunlun-R200的CI都是这个类型有问题。

luotao1 · 2023-12-20T03:32:49Z

@zeroRains

fused_gemm_epilogue： @YuanRisheng 在找高版本CUDA机器和kunlun机器复现
identity_loss：可以分开提PR，先完成 add the yaml of identity_loss

YuanRisheng · 2023-12-20T11:45:34Z

@zeroRains sig文件写的有问题，这样改试试：

KernelSignature FusedGemmEpilogueGradOpArgumentMapping(
    const ArgumentMappingContext& ctx) {
  return KernelSignature("fused_gemm_epilogue_grad",
                         {"X", "Y", "ReserveSpace","DOut"},
                         {"trans_x", "trans_y", "activation_grad"},
                         {"DX", "DY", "DBias"});
}

zeroRains · 2023-12-21T01:13:57Z

@YuanRisheng 好像可以了

zyfncg · 2023-12-21T03:00:48Z

paddle/phi/api/yaml/ops.yaml

+    data_type : x
+    backend : x


输入tensor只有一个x, 这里的dtype和backend可以不配置

zyfncg · 2023-12-21T03:01:31Z

paddle/phi/infermeta/binary.h

+void IdentityLossGradInferMeta(const MetaTensor& x,
+                               const MetaTensor& out_grad,
+                               const int reduction,
+                               MetaTensor* x_grad);
+


InferMeta函数按照字母序放置

try to move fused_gemm_epilogue to phi

341afcc

paddle-bot bot added the contributor External developers label Nov 25, 2023

zeroRains changed the title ~~【Hackathon 5th No.103】 move fused_gemm_epilogue to phi- part~~ 【Hackathon 5th No.112】 move fused_gemm_epilogue to phi- part Nov 25, 2023

zeroRains added 2 commits November 25, 2023 10:52

try to fix bug

31eb4eb

update

fafe072

luotao1 mentioned this pull request Nov 26, 2023

【PaddlePaddle Hackathon 5th】开源贡献个人挑战赛 #57262

Open

luotao1 added the PaddlePaddle Hackathon label Nov 29, 2023

luotao1 assigned luotao1, 0x45f and YuanRisheng Nov 29, 2023

YuanRisheng reviewed Nov 29, 2023

View reviewed changes

YuanRisheng mentioned this pull request Nov 29, 2023

【Hackathon 5th No.112】move read_file to phi - part #59359

Merged

fix the bug in config

6f7a3d7

zeroRains changed the title ~~【Hackathon 5th No.112】 move fused_gemm_epilogue to phi- part~~ 【Hackathon 5th No.112】 move fused_gemm_epilogue to phi and add the yaml of identity_los- part Dec 1, 2023

zeroRains changed the title ~~【Hackathon 5th No.112】 move fused_gemm_epilogue to phi and add the yaml of identity_los- part~~ 【Hackathon 5th No.112】move fused_gemm_epilogue to phi and add the yaml of identity_loss- part Dec 1, 2023

zeroRains added 3 commits December 2, 2023 03:07

fix the bug

d5d895e

config the identity_loss of yaml

628cc43

fix bug

456022c

YuanRisheng reviewed Dec 4, 2023

View reviewed changes

zeroRains added 7 commits December 4, 2023 11:02

temp

249dc76

fix bug

3a74701

remove the #include

3f1de5b

Merge branch 'develop' of https://github.com/PaddlePaddle/Paddle into…

1b0c20a

… 112_fused

Merge branch 'develop' of https://github.com/PaddlePaddle/Paddle into…

cb4da1b

… 112_fused

roback

96a92f6

remove file in fluid

b05872d

zeroRains added 12 commits December 10, 2023 05:51

add the output in op_comat

6cbe87d

try to move xpu

bc1ec4a

fix config

6531fb7

roback the flashatten

c98a435

change the ops/compate

12a8411

move the typename to kernel

b616534

remove VLOG

29f0b5c

fix bug

7878144

remove the same define

8841394

fix bug

1e64184

roback the sig file

5aa79a0

Merge branch 'develop' of https://github.com/PaddlePaddle/Paddle into…

c41b7eb

… 112_fused

zeroRains force-pushed the 112_fused branch 2 times, most recently from 4c34b68 to c41b7eb Compare December 16, 2023 06:18

zeroRains added 2 commits December 20, 2023 20:09

Update fused_gemm_epilogue_sig.cc

cc19bea

Update fused_gemm_epilogue_sig.cc

fca12a8

YuanRisheng previously approved these changes Dec 21, 2023

View reviewed changes

luotao1 changed the title ~~【Hackathon 5th No.112】move fused_gemm_epilogue to phi and add the yaml of identity_loss- part~~ 【Hackathon 5th No.112】move fused_gemm_epilogue to phi and add the yaml of identity_loss Dec 21, 2023

zyfncg reviewed Dec 21, 2023

View reviewed changes

fix a small bug

ac92a3d

zeroRains dismissed YuanRisheng’s stale review via ac92a3d December 21, 2023 03:55

zyfncg approved these changes Dec 21, 2023

View reviewed changes

luotao1 merged commit 3976459 into PaddlePaddle:develop Dec 21, 2023
29 checks passed

zeroRains mentioned this pull request Dec 21, 2023

【Hackathon 5th No.112】add the config of identitiy_loss -part #60178

Closed

zeroRains deleted the 112_fused branch January 30, 2024 12:46

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

【Hackathon 5th No.112】move fused_gemm_epilogue to phi and add the yaml of identity_loss #59363

【Hackathon 5th No.112】move fused_gemm_epilogue to phi and add the yaml of identity_loss #59363

zeroRains commented Nov 25, 2023

paddle-bot bot commented Nov 25, 2023

zeroRains commented Nov 25, 2023 •

edited

Loading

YuanRisheng Nov 29, 2023

zeroRains Nov 29, 2023

YuanRisheng commented Nov 29, 2023 •

edited

Loading

zeroRains commented Nov 29, 2023

YuanRisheng Dec 4, 2023

YuanRisheng Dec 4, 2023

zeroRains commented Dec 16, 2023

luotao1 commented Dec 20, 2023

YuanRisheng commented Dec 20, 2023 •

edited

Loading

zeroRains commented Dec 21, 2023

zyfncg Dec 21, 2023

zyfncg Dec 21, 2023

【Hackathon 5th No.112】move fused_gemm_epilogue to phi and add the yaml of identity_loss #59363

【Hackathon 5th No.112】move fused_gemm_epilogue to phi and add the yaml of identity_loss #59363

Conversation

zeroRains commented Nov 25, 2023

PR types

PR changes

Description

paddle-bot bot commented Nov 25, 2023

zeroRains commented Nov 25, 2023 • edited Loading

YuanRisheng Nov 29, 2023

Choose a reason for hiding this comment

zeroRains Nov 29, 2023

Choose a reason for hiding this comment

YuanRisheng commented Nov 29, 2023 • edited Loading

zeroRains commented Nov 29, 2023

YuanRisheng Dec 4, 2023

Choose a reason for hiding this comment

YuanRisheng Dec 4, 2023

Choose a reason for hiding this comment

zeroRains commented Dec 16, 2023

luotao1 commented Dec 20, 2023

YuanRisheng commented Dec 20, 2023 • edited Loading

zeroRains commented Dec 21, 2023

zyfncg Dec 21, 2023

Choose a reason for hiding this comment

zyfncg Dec 21, 2023

Choose a reason for hiding this comment

zeroRains commented Nov 25, 2023 •

edited

Loading

YuanRisheng commented Nov 29, 2023 •

edited

Loading

YuanRisheng commented Dec 20, 2023 •

edited

Loading