Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PIR]support reduce_min reduce_pro mod flood_div ops #59650

Conversation

phlrain
Copy link
Collaborator

@phlrain phlrain commented Dec 4, 2023

PR types

New features

PR changes

Others

Description

适配cinn中的 reduce_min, reduce_prod, mod, flood_div算子

Pcard-67164

Copy link

paddle-bot bot commented Dec 4, 2023

你的PR提交成功,感谢你对开源项目的贡献!
请关注后续CI自动化测试结果,详情请参考Paddle-CI手册
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

Copy link

paddle-bot bot commented Dec 4, 2023

✅ This PR's description meets the template requirements!
Please wait for other CI results.

@phlrain phlrain changed the title Pir cinn jit instruction support no need buffer [PIR]support reduce_min reduce_pro mod flood_div ops Dec 5, 2023
Copy link
Contributor

@Aurelius84 Aurelius84 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@@ -42,6 +42,10 @@ const std::unordered_map<std::string, std::string> CompatibleInfo::OP_NAMES = {
{"pd_op.add", "elementwise_add"},
{"pd_op.elementwise_pow", "pow"},
{"pd_op.multiply", "elementwise_mul"},
{"pd_op.remainder", "remainder"},
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
{"pd_op.remainder", "remainder"},
{"cinn_op.remainder", "remainder"},

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

应该是删除

@@ -42,6 +42,10 @@ const std::unordered_map<std::string, std::string> CompatibleInfo::OP_NAMES = {
{"pd_op.add", "elementwise_add"},
{"pd_op.elementwise_pow", "pow"},
{"pd_op.multiply", "elementwise_mul"},
{"pd_op.remainder", "remainder"},
{"pd_op.floor_divide", "floor_divide"},
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
{"pd_op.floor_divide", "floor_divide"},
{"cinn_op.floor_divide", "floor_divide"},

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这里是不是应该为 cinn_op.xx ?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

应该是删除

@phlrain phlrain merged commit 2d78a6b into PaddlePaddle:develop Dec 6, 2023
29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants