[XPU][PHI Kernels] Support bf16 for fused_rope #60064
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
你的PR提交成功，感谢你对开源项目的贡献! |
lj970926
commented
Dec 18, 2023
| PADDLE_ENFORCE_XDNN_SUCCESS(ret, "gather"); | ||
| using XPUTFp16 = typename XPUTypeTrait<phi::dtype::float16>::Type; | ||
| using XPUTBf16 = typename XPUTypeTrait<phi::dtype::bfloat16>::Type; | ||
| if (std::is_same<XPUT, XPUTBf16>::value) { |
There was a problem hiding this comment.
这里因为当时提PR的时候还没有支持bf16 gather的相关产出，所以暂时用了FP16，后续PR会改回BF16
lj970926
commented
Dec 18, 2023
| self.shape = [2, 8, 2, 16] | ||
|
|
||
| def test_api(self): | ||
| q_fp32 = paddle.rand(self.shape, dtype="float32") |
There was a problem hiding this comment.
这里BF16的单测如果用non_fusion的实现会遇到暂时不支持bf16的其他kernel，所以暂时和fp32的融合算子比
HarperCy
approved these changes
Dec 19, 2023
houj04
approved these changes
Dec 19, 2023
XiaociZhang
reviewed
Dec 19, 2023
| @@ -75,4 +75,5 @@ PD_REGISTER_KERNEL(c_embedding, | |||
| ALL_LAYOUT, | |||
| phi::CEmbeddingKernel, | |||
| float, | |||
| phi::dtype::float16) {} | |||
There was a problem hiding this comment.
api最新代码 embedding 似乎还不支持bf16，再确认下？
| @@ -86,4 +86,5 @@ PD_REGISTER_KERNEL(c_embedding_grad, | |||
| ALL_LAYOUT, | |||
| phi::CEmbeddingGradKernel, | |||
| float, | |||
| phi::dtype::float16) {} | |||
| @@ -32,6 +32,7 @@ def test_identity(self): | |||
| "float64", | |||
| "int32", | |||
| "int64", | |||
| "bfloat16", | |||
There was a problem hiding this comment.
单测修改看起来没问题，本地ctest验证过吗，我不确定这几个算子是否在CI黑名单里
|
LGTM |
HermitSun
pushed a commit
to HermitSun/Paddle
that referenced
this pull request
Dec 21, 2023
* support fused_rope fp16 * bug fix * bug fix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
New features
PR changes
OPs
Description