Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pir] add __neg__ and clean pir.cc #60166

Merged
merged 7 commits into from
Dec 22, 2023
Merged

Conversation

gouzil
Copy link
Member

@gouzil gouzil commented Dec 19, 2023

PR types

Others

PR changes

Others

Description

添加__neg__并清理pir.ccBindValue

相关链接:

Copy link

paddle-bot bot commented Dec 19, 2023

你的PR提交成功,感谢你对开源项目的贡献!
请关注后续CI自动化测试结果,详情请参考Paddle-CI手册
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@paddle-bot paddle-bot bot added the contributor External developers label Dec 19, 2023
@PaddlePaddle PaddlePaddle locked and limited conversation to collaborators Dec 19, 2023
@PaddlePaddle PaddlePaddle unlocked this conversation Dec 19, 2023
@@ -513,6 +516,7 @@ def value_hash(self):
('append', append),
('set_shape', set_shape),
('__hash__', value_hash),
# For basaic operators
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
# For basaic operators
# For basic operators

OVERRIDE_COMPARE_OP_FOR_EACH(__lt__, less_than);
OVERRIDE_COMPARE_OP_FOR_EACH(__le__, less_equal);
OVERRIDE_COMPARE_OP_FOR_EACH(__gt__, greater_than);
OVERRIDE_COMPARE_OP_FOR_EACH(__ge__, greater_equal);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

看看这俩宏还有用到么,没用一起删了吧

Copy link
Member

@SigureMo SigureMo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTMeow

@SigureMo SigureMo merged commit bc7380d into PaddlePaddle:develop Dec 22, 2023
29 checks passed
@gouzil gouzil deleted the pir_method_neg branch January 25, 2024 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contributor External developers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants