Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Dy2St][NO.11] pir dy2st unittest fix test_save_inference_model - Part 3 #60211

Merged
merged 4 commits into from
Dec 21, 2023

Conversation

gouzil
Copy link
Member

@gouzil gouzil commented Dec 21, 2023

PR types

Others

PR changes

Others

Description

修复打开TestPartialProgramRaiseError单测

TestDyToStaticSaveInferenceModel如果我没看错的话,这个单测应该要等PyLayer

相关链接:

Copy link

paddle-bot bot commented Dec 21, 2023

你的PR提交成功,感谢你对开源项目的贡献!
请关注后续CI自动化测试结果,详情请参考Paddle-CI手册
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@paddle-bot paddle-bot bot added the contributor External developers label Dec 21, 2023
@gouzil gouzil changed the title [Dy2St][NO.14] pir dy2st unittest fix test_save_inference_model - Part 3 [Dy2St][NO.11] pir dy2st unittest fix test_save_inference_model - Part 3 Dec 21, 2023
partial_program_from(concrete_program)

# Under PIR, params are tuples and cannot be modified
if not use_pir_api():
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这里也可以考虑把with self.assertRaises(TypeError):移上来,这样就不需要跳过pir_api

@gouzil gouzil requested a review from SigureMo December 21, 2023 06:21
Copy link
Member

@SigureMo SigureMo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTMeow

@gouzil gouzil merged commit d6f6402 into PaddlePaddle:develop Dec 21, 2023
29 checks passed
@gouzil gouzil deleted the dy2st_pir_api_fix_3 branch January 25, 2024 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contributor External developers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants