[XPU][Phi Kernel] xpu::nonzero support simulator XPUSIM_SKIP_RUN mode #60388
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
你的PR提交成功，感谢你对开源项目的贡献! |
dynamicheart
force-pushed
the
xpu_nonzero_simulator_skip_run_mode
branch
from
0ad5720
to
31b4997
Compare
dynamicheart
force-pushed
the
xpu_nonzero_simulator_skip_run_mode
branch
from
31b4997
to
938283f
Compare
dynamicheart
commented
Dec 27, 2023
| << "WARNING: In the simulator mode, the variable non_zero_cpu " | ||
| "stores an uninitialized value. To avoid allocating a memory of " | ||
| "random size, we assign numel to true_num_cpu"; | ||
| non_zero_cpu = x.numel(); |
There was a problem hiding this comment.
sigmoid_cross_entropy_with_logits的单测比较难写，尝试了几种方法都不好调用。这样的写法在其它cases下已经测试过，没有问题。
dynamicheart
commented
Dec 28, 2023
| @@ -46,9 +46,8 @@ void NonZeroKernel(const Context& dev_ctx, | |||
| std::strcmp(std::getenv("XPUSIM_SKIP_RUN"), "1") == 0) { | |||
| VLOG(3) << "WARNING: In the simulator mode, the variable true_num_cpu " | |||
| "stores an uninitialized value. To avoid allocating a memory of " | |||
| "random size, we limit the value of true_num_cpu to the range 0 " | |||
| "<= true_num_cpu < numel"; | |||
| true_num_cpu = std::min(std::max(true_num_cpu, 0), static_cast<int>(numel)); | |||
There was a problem hiding this comment.
某些case下会被设为0，后续的模型代码可能会报错，因此还是将其设为最大值。单测在这个PR里面：#60224
cqulilujia
approved these changes
Dec 28, 2023
| VLOG(3) << "WARNING: In the simulator mode, the variable out_size_cpu " | ||
| "stores an uninitialized value. To avoid allocating a memory of " | ||
| "random size, we assign numel to out_size_cpu"; | ||
| out_size_cpu = mask.numel(); |
There was a problem hiding this comment.
写死最大对后续算子的影响还需要实际跑模型的时候再评估下
There was a problem hiding this comment.
skip_run拿不到不出来真实规模，也可能每个step对应的nonzero_count相关算子的规模也不一样
There was a problem hiding this comment.
很好的意见，后续有时间可以看看这个算子在模型中的位置以及它的返回值影响的范围。
QingshuChen
approved these changes
Dec 29, 2023
Wanglongzhi2001
pushed a commit
to Wanglongzhi2001/Paddle
that referenced
this pull request
Jan 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
New features
PR changes
OPs
Description
xdnn::nonzerosupport simulator XPUSIM_SKIP_RUN mode.true_num_cpustores an uninitialized value. To avoid allocating a memory of random size, we assignnumelto it.true_num_cpu = std::min(std::max(true_num_cpu, 0), static_cast<int>(numel));may lead to the failure of the following kernel in the case thattrue_num_cpuis set to0.Similar to PR: #60224.