Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the proformance problem of enforce #6085

Merged
merged 4 commits into from
Dec 1, 2017
Merged

Fix the proformance problem of enforce #6085

merged 4 commits into from
Dec 1, 2017

Conversation

reyoung
Copy link
Collaborator

@reyoung reyoung commented Nov 30, 2017 •
edited
Loading

Fix #6095
Fix #6106

@reyoung reyoung changed the title Fix Proformance problem of enforce Fix the proformance problem of enforce Nov 30, 2017
dzhwinter
dzhwinter previously approved these changes Nov 30, 2017
View reviewed changes
Copy link
Contributor

@dzhwinter dzhwinter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great fix.

@reyoung reyoung added this to the Release 0.11.0 milestone Nov 30, 2017
dzhwinter
dzhwinter previously approved these changes Nov 30, 2017
View reviewed changes
Copy link
Contributor

@dzhwinter dzhwinter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good

jacquesqiao
jacquesqiao approved these changes Nov 30, 2017
View reviewed changes
Copy link
Member

@jacquesqiao jacquesqiao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@reyoung reyoung merged commit 8ac0227 into PaddlePaddle:develop Dec 1, 2017
@reyoung reyoung deleted the feature/fix_enforce_string branch December 26, 2017 09:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jacquesqiao jacquesqiao jacquesqiao approved these changes

@dzhwinter dzhwinter dzhwinter left review comments

Assignees
No one assigned
Labels
performance tuning
Projects
None yet
Milestone
Release 0.11.0
Development

Successfully merging this pull request may close these issues.
3 participants
@reyoung @jacquesqiao @dzhwinter