[Dynamic shape] Delete SymbolicDimMgr symbolTable and SymbolicDimOp #60933
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
你的PR提交成功，感谢你对开源项目的贡献! |
zhangbopd
changed the title
jiahy0825
reviewed
Jan 18, 2024
Comment on lines
+76
to
+88
| if (lhs == rhs) return true; | ||
| // auto lhs_type = lhs.type().dyn_cast<ShapedTypeInterface>(); | ||
| // auto rhs_type = rhs.type().dyn_cast<ShapedTypeInterface>(); | ||
|
|
||
| // if (!lhs_type || !rhs_type || !lhs_type.HasRank() || !rhs_type.HasRank()) | ||
| // return false; | ||
|
|
||
| // return IsProductEqual(lhs, | ||
| // 0, | ||
| // static_cast<int>(lhs_type.GetRank()), | ||
| // rhs, | ||
| // 0, | ||
| // static_cast<int>(rhs_type.GetRank())); |
There was a problem hiding this comment.
这里接口需要保留、逻辑相同但是需要使用新的数据结构进行重构，注释掉为是保留了逻辑，后续PR会马上使用dim_expr 完成接口功能
Comment on lines
+94
to
+102
| // std::vector<int> lhs_dim_idxs, rhs_dim_idxs; | ||
|
|
||
| // lhs_dim_idxs.reserve(lhs_to - lhs_from); | ||
| // rhs_dim_idxs.reserve(rhs_to - rhs_from); | ||
|
|
||
| // for (int i = lhs_from; i < lhs_to; ++i) lhs_dim_idxs.push_back(i); | ||
| // for (int i = rhs_from; i < rhs_to; ++i) rhs_dim_idxs.push_back(i); | ||
|
|
||
| // return IsProductEqual(lhs, lhs_dim_idxs, rhs, rhs_dim_idxs); |
Comment on lines
+179
to
+186
| auto it = tables_.find(program->module_op().operation()->id()); | ||
|
|
||
| if (it == tables_.end()) { | ||
| it = tables_ | ||
| .emplace(program->module_op().operation()->id(), | ||
| ShapeConstraintIRAnalysis(program->module_op())) | ||
| .first; | ||
| } |
There was a problem hiding this comment.
这里当时设计时和 liujie 讨论根据 program 作为 key 的，当时这里记了一个 todo
lanxianghit
reviewed
Jan 19, 2024
|
|
||
| return val.defining_op()->name() + "_" + std::to_string(op_id) + "_rst_" + | ||
| std::to_string(val_idx); | ||
| } |
There was a problem hiding this comment.
这个文件里有些也可以清理掉，GetValueId现在应该也用不到了吧，可以后续PR再删掉
There was a problem hiding this comment.
这个是 zynncg PR 中加的用来debug 的、之前 GetValueId 已经清理过一次了
|
|
||
| void VerifySig() {} | ||
| }; | ||
|
|
||
| class IR_API DimOp : public Op<DimOp> { |
There was a problem hiding this comment.
不需要了、本来想下个PR 清理 刚好 PR 冲突了，我继续在这个 PR 中清理吧
| TieProductEqualOp, | ||
| TieShapeOp, | ||
| FuncOp, | ||
| RegisterOps<DimOp, |
lanxianghit
previously approved these changes
Jan 19, 2024
刚好 PR 冲突了，我继续在这个 PR 中清理吧 |
… is_shape_equal
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Others
PR changes
Others
Description
Pcard-67164