Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Dy2St] Shrink the eval scope #61149

Merged
merged 1 commit into from
Jan 25, 2024

Conversation

SigureMo
Copy link
Member

PR types

Others

PR changes

Others

Description

收缩 eval 使用范围,eval 应该仅仅对已经是字符串的部分使用,外部函数不应该使用,否则函数引用不清晰,会引入 F401,而且很难知道 eval 都用到了哪些外部变量

PCard-66972

@SigureMo SigureMo requested a review from gouzil January 25, 2024 01:40
Copy link
Member

@gouzil gouzil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gouzil gouzil merged commit 3aa0926 into PaddlePaddle:develop Jan 25, 2024
29 of 30 checks passed
@gouzil gouzil deleted the dy2st/shrink-eval-scope branch January 25, 2024 05:35
eee4017 pushed a commit to eee4017/Paddle that referenced this pull request Jan 30, 2024
Copy link

paddle-bot bot commented Feb 4, 2024

你的PR提交成功,感谢你对开源项目的贡献!
请关注后续CI自动化测试结果,详情请参考Paddle-CI手册
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants