Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PIR] Open some cf ut for pir api #61182

Merged
merged 2 commits into from
Jan 29, 2024

Conversation

zhangbo9674
Copy link
Contributor

PR types

Others

PR changes

Others

Description

Open some cf ut for pir api
Pcard-67164

Copy link
Member

@SigureMo SigureMo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTMeow

@@ -203,8 +202,6 @@ def run_dygraph(self, func):
y = func()
return (y,)

# TODO: Open PIR test when while_loop dy2st fixed
@test_legacy_and_pt
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这个删不删是没有区别的,默认就是 LEGACY_IR + PT,这是符合预期的嘛?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

符合预期,这个单测还未开启

@@ -203,8 +202,6 @@ def run_dygraph(self, func):
y = func()
return (y,)

# TODO: Open PIR test when while_loop dy2st fixed
@test_legacy_and_pt
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这个单测是还没有开启pir吗

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

是的

@zhangbo9674 zhangbo9674 merged commit f9b8c6c into PaddlePaddle:develop Jan 29, 2024
29 of 30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants