Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PIR] Support pop for TensorArray #61192

Merged
merged 11 commits into from
Jan 29, 2024

Conversation

SigureMo
Copy link
Member

@SigureMo SigureMo commented Jan 25, 2024

PR types

New features

PR changes

Others

Description

为 TensorArray 支持 pop 操作,为 inplace 操作,IR 表示层输入 TensorArray 输出自身 TensorArray 和 pop_item

移除无用的 _jst.Pop,移动 _run_paddle_pop 逻辑到唯一的调用处 Variable.pop

PCard-67164

Copy link
Contributor

@zhangbo9674 zhangbo9674 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@sunzhongkai588 sunzhongkai588 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@XiaoguangHu01 XiaoguangHu01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SigureMo SigureMo merged commit c2281df into PaddlePaddle:develop Jan 29, 2024
30 checks passed
@SigureMo SigureMo deleted the pir/support-tensor-array-pop branch January 29, 2024 07:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants