[PIR][DynamicShape] Add InferSymbolicShape for gather_nd, squeeze, and unsqueeze #61224
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhangbopd
reviewed
Jan 29, 2024
| @@ -607,8 +656,91 @@ bool ScaleSr_OpInferSymbolicShape( | |||
|
|
|||
| bool SqueezeOpInferSymbolicShape( | |||
| pir::Operation *op, pir::ShapeConstraintIRAnalysis *shape_analysis) { | |||
| PADDLE_THROW(phi::errors::Unimplemented( | |||
| op->name() + " DOES NOT have InferSymbolicShapeInterface!")); | |||
| IR_ENFORCE(op->num_operands() == 2, | |||
There was a problem hiding this comment.
这部分是不是会在 verify 或者 infermeta 函数中检查过了？ 所以 此处不需要再重复检查了
There was a problem hiding this comment.
我看pd_op里还有其他build的定义，不确定是否还有其他形式的，所以先做个检查，以免直接越界了
zhangbopd
approved these changes
Jan 29, 2024
| // Mark dimensions need to be squeezed. | ||
| if (num_squeeze_dims == 0) { | ||
| for (size_t i = 0; i < in_dims_sym.size(); ++i) { | ||
| // TODO(lanxianghit): if symbol here, maybe we need the result of dim expr |
There was a problem hiding this comment.
这个头文件的函数可以对 dim_expr 实现化简 已经从 cinn 移动到 shape dialect 下了
#include "paddle/pir/dialect/shape/utils/dim_expr_simplify.h"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Others
PR changes
Others
Description
Pcard-67164
Add InferSymbolicShape for gather_nd, squeeze, and unsqueeze, which used in RoPE