[CINN+PIR]Fix IsSupportCINN Logic #61225
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Aurelius84
commented
Jan 26, 2024
| auto value = op.operand_source(i); | ||
| if (value && value.type()) { | ||
| auto value_type = value.type(); | ||
| if (value_type.isa<::pir::VectorType>() && |
There was a problem hiding this comment.
concat 是因为其输入是一个VectorType，导致AllInputDenseTensor返回了False，因此这里扩充了这个分支，即可修复此问题
Aurelius84
commented
Jan 26, 2024
| @@ -56,6 +56,7 @@ const std::unordered_map<std::string, std::string> CompatibleInfo::OP_NAMES = { | |||
| {"pd_op.split_with_num", "split"}, | |||
| {"pd_op.reshape", "reshape"}, | |||
| {"pd_op.expand", "broadcast_to"}, | |||
| {"pd_op.concat", "concat"}, | |||
There was a problem hiding this comment.
这个名单在过渡期其实应该只有一个角色：即处理PIR与CINN AST端 OpName 映射不一致的问题，已清理逻辑
tc20042008
reviewed
Jan 26, 2024
| @@ -133,32 +134,62 @@ bool UnimplementOps(const ::pir::Operation& op) { | |||
| bool HaveZeroDimInput(const ::pir::Operation& op) { | |||
There was a problem hiding this comment.
可以把这里的代码整理成如下风格吗？
auto MatchXXX = [&](int i) {
...
};
auto MatchYYY = [&](int i) {
...
};
for (size_t i = 0; i < op.num_operands(); ++i) {
if (MatchXXX(i)) return true;
if (MatchYYY(i)) return true;
}
return false;尽可能减少圈复杂度。提高可读性。
There was a problem hiding this comment.
Thanks for advice, fixed
zyfncg
approved these changes
Jan 26, 2024
tc20042008
approved these changes
Jan 27, 2024
eee4017
pushed a commit
to eee4017/Paddle
that referenced
this pull request
Jan 30, 2024
* [CINN+PIR]Fix IsSupportCINN Logic * fix comment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Bug fixes
PR changes
Others
Description
Pcard-67164
修复后，scale和concat都可以融合进group 子图了
