[PIR][DynamicShape] Add InferSymbolicShape interfaces for llama ops #61439
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zyfncg
approved these changes
Feb 1, 2024
Comment on lines
+189
to
+197
| bool ArangeOpInferSymbolicShape(pir::Operation *op, | ||
| pir::ShapeConstraintIRAnalysis *shape_analysis); | ||
|
|
||
| bool EmbeddingOpInferSymbolicShape( | ||
| pir::Operation *op, pir::ShapeConstraintIRAnalysis *shape_analysis); | ||
|
|
||
| bool SparseWeightEmbeddingOpInferSymbolicShape( | ||
| pir::Operation *op, pir::ShapeConstraintIRAnalysis *shape_analysis); | ||
|
|
There was a problem hiding this comment.
是的，有这个计划，，而且一个文件里算子太多了，编译和冲突的问题也越来越多，后面考虑统一拆分和整理一下
zyfncg
reviewed
Feb 1, 2024
| @@ -77,6 +77,7 @@ | |||
| backend : place | |||
| data_transform : | |||
| support_trans_dtype : start, end, step | |||
| interfaces : paddle::dialect::InferSymbolicShapeInterface | |||
There was a problem hiding this comment.
不太确定legacy_ops.yaml里的算子在动转静流程里还会不会生效，可能需要确认下
There was a problem hiding this comment.
这个跟陈卓确认过，但具体可能还要具体测试一下看看
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Others
PR changes
Others
Description
Pcard-67164
先一次性添加LLaMA中可能用到算子的InferSymbolicShape interfaces，以免每次都需要更改yaml