Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PIR] Add enforce for ArrayWrite & add dims for DenseTensorArrayType & open test #61450

Merged
merged 10 commits into from
Feb 7, 2024
Merged

[PIR] Add enforce for ArrayWrite & add dims for DenseTensorArrayType & open test #61450

merged 10 commits into from
Feb 7, 2024

Conversation

chen2016013
Copy link
Contributor

@chen2016013 chen2016013 commented Feb 1, 2024 •
edited
Loading

PR types

Others

PR changes

Others

Description

Pcard-67164

问题：

  • concat api 不支持 tensorarray
  • slice array 由于 tensorarray 的 shape 为0，校验报错

解决：

  • concat api 支持 tensorarray
  • 为DenseTensorArrayType添加dims并在array_write时更新

zhangbo9674
zhangbo9674 reviewed Feb 2, 2024
View reviewed changes
test/dygraph_to_static/test_list.py Show resolved Hide resolved
test/dygraph_to_static/test_list.py Outdated Show resolved Hide resolved
test/dygraph_to_static/test_list.py Outdated Show resolved Hide resolved
@chen2016013 chen2016013 changed the title [PIR] Add enforce for ArrayWrite & open test [PIR] Add enforce for ArrayWrite & add dims for densetensorarraytype & open test Feb 4, 2024
@chen2016013 chen2016013 changed the title [PIR] Add enforce for ArrayWrite & add dims for densetensorarraytype & open test [PIR] Add enforce for ArrayWrite & add dims for DenseTensorArrayType & open test Feb 4, 2024
zhangbo9674
zhangbo9674 reviewed Feb 4, 2024
View reviewed changes
paddle/fluid/pir/dialect/operator/ir/manual_op.cc Outdated Show resolved Hide resolved
paddle/fluid/pir/dialect/operator/ir/manual_op.cc Outdated Show resolved Hide resolved
paddle/fluid/pir/dialect/operator/ir/op_type.cc Outdated Show resolved Hide resolved
paddle/phi/core/meta_tensor.cc Show resolved Hide resolved
SigureMo
SigureMo approved these changes Feb 6, 2024
View reviewed changes
Copy link
Member

@SigureMo SigureMo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTMeow

@chen2016013 chen2016013 merged commit e06048d into PaddlePaddle:develop Feb 7, 2024
30 checks passed
@chen2016013 chen2016013 deleted the test0201 branch February 21, 2024 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zhangbo9674 zhangbo9674 zhangbo9674 approved these changes

@SigureMo SigureMo SigureMo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@chen2016013 @SigureMo @zhangbo9674