Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Dy2St] Use hand write unparse instead of astor in Python3.8 #61540

Conversation

SigureMo
Copy link
Member

@SigureMo SigureMo commented Feb 3, 2024

PR types

Others

PR changes

Others

Description

修复 #61480 在 Python 3.8 环境下没有 astor 导致挂掉的问题,手写一个简单的 unparse 替代 astor(因为我们的使用场景有限,手写的基本可以满足,全量动转静单测测试也是通过的)

PR-CI-APPROVAL 环境里随机 Python 3.8 和 Python 3.9 就离谱

PCard-66972

@SigureMo SigureMo requested a review from gouzil February 3, 2024 14:12
Copy link
Member

@gouzil gouzil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SigureMo SigureMo merged commit 0e3f93c into PaddlePaddle:develop Feb 4, 2024
31 of 32 checks passed
@SigureMo SigureMo deleted the dy2st/use-hand-write-unparse-instead-of-astor branch February 4, 2024 01:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants