[SOT] update SIR export check, add _reconstruct for TensorDtypeVariable #61822
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
你的PR提交成功，感谢你对开源项目的贡献! |
SigureMo
reviewed
Feb 20, 2024
| @@ -284,6 +284,10 @@ def get_py_type(self): | |||
| return paddle.pir.core.DataType | |||
| return super().get_py_type() | |||
|
|
|||
| def _reconstruct(self, codegen: PyCodeGen): | |||
| # dtype of paddle.Tensor is hashable, we can just load it as const var | |||
| codegen.gen_load_const(self.value) | |||
There was a problem hiding this comment.
这里在 PIR 下应该也需要上面 get_py_value 和 get_py_type 一样的检查并 vartype_to_datatype 才行吧，不然应该组网会挂
另外这个没有加单测么？
SigureMo
previously approved these changes
Feb 20, 2024
SigureMo
approved these changes
Feb 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Others
PR changes
Others
Description
update SIR export check, add _reconstruct for TensorDtypeVariable
PCard-66972