Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PIR] Add op_callstack to Pir #62139

Merged
merged 17 commits into from
Mar 6, 2024
Merged

[PIR] Add op_callstack to Pir #62139

merged 17 commits into from
Mar 6, 2024

Conversation

xingmingyyj
Copy link
Contributor

@xingmingyyj xingmingyyj commented Feb 27, 2024 •
edited
Loading

PR types

Others

PR changes

Others

Description

Pir适配op_callstack属性，对齐旧IR下的报错机制。
Pir下报错形式如下：

655:     File "/home/aistudio/add_opcallstack/Paddle/tools/test_runner.py", line 83, in <module>
655:       main()
655:     File "/home/aistudio/add_opcallstack/Paddle/tools/test_runner.py", line 65, in main
655:       res = unittest.TextTestRunner(stream=buffer).run(tests)
655:     File "/usr/lib/python3.8/unittest/runner.py", line 176, in run
655:       test(result)
655:     File "/usr/lib/python3.8/unittest/suite.py", line 84, in __call__
655:       return self.run(*args, **kwds)
655:     File "/usr/lib/python3.8/unittest/suite.py", line 122, in run
655:       test(result)
655:     File "/usr/lib/python3.8/unittest/suite.py", line 84, in __call__
655:       return self.run(*args, **kwds)
655:     File "/usr/lib/python3.8/unittest/suite.py", line 122, in run
655:       test(result)
655:     File "/usr/lib/python3.8/unittest/case.py", line 736, in __call__
655:       return self.run(*args, **kwds)
655:     File "/usr/lib/python3.8/unittest/case.py", line 676, in run
655:       self._callTestMethod(testMethod)
655:     File "/usr/lib/python3.8/unittest/case.py", line 633, in _callTestMethod
655:       method()
655:     File "/home/aistudio/add_opcallstack/Paddle/build/test/legacy_test/test_array_read_write_op.py", line 270, in test_create_array_like_add_n
655:       add_array = paddle._pir_ops.add_n_array([mem_array, copy_array])

@paddle-bot Paddle-bot
Copy link

paddle-bot bot commented Feb 27, 2024

你的PR提交成功，感谢你对开源项目的贡献!
请关注后续CI自动化测试结果，详情请参考Paddle-CI手册。
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@paddle-bot paddle-bot bot added the contributor External developers label Feb 27, 2024
@SigureMo SigureMo self-assigned this Feb 29, 2024
@SigureMo
Copy link
Member

SigureMo commented Mar 5, 2024

Description

Others

简单写一下 PR 描述吧

SigureMo
SigureMo previously approved these changes Mar 5, 2024
View reviewed changes
Copy link
Member

@SigureMo SigureMo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTMeow 🐾

@SigureMo SigureMo changed the title Add op_callstack to Pir [PIR] Add op_callstack to Pir Mar 5, 2024
SigureMo
SigureMo reviewed Mar 5, 2024
View reviewed changes
paddle/cinn/hlir/framework/pir/utils.cc Outdated
dst_attr.push_back(
element.dyn_cast<::pir::StrAttribute>().AsString());
}
dst_attr = dst_attr;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

啊，这里忘记删掉了，如果没有其他问题的话下个 PR 再删吧

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

新增的 op_callstack 是 Array<Str> 所以这里加了相关处理

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

已删除

kangguangli
kangguangli previously approved these changes Mar 5, 2024
View reviewed changes
Aurelius84
Aurelius84 reviewed Mar 5, 2024
View reviewed changes
Copy link
Contributor

@Aurelius84 Aurelius84 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job

paddle/fluid/pybind/op_callstack_utils.h Outdated Show resolved Hide resolved
paddle/fluid/pybind/op_callstack_utils.h Outdated Show resolved Hide resolved
paddle/fluid/pybind/op_callstack_utils.cc Outdated Show resolved Hide resolved
paddle/fluid/pybind/op_callstack_utils.cc Outdated Show resolved Hide resolved
paddle/fluid/pybind/op_callstack_utils.cc Outdated Show resolved Hide resolved
paddle/fluid/pybind/op_callstack_utils.h Outdated Show resolved Hide resolved
paddle/fluid/pybind/op_callstack_utils.h Outdated Show resolved Hide resolved
0x45f
0x45f previously approved these changes Mar 5, 2024
View reviewed changes
@xingmingyyj xingmingyyj dismissed stale reviews from 0x45f, kangguangli, and SigureMo via a0f2a67 March 5, 2024 09:33
@SigureMo SigureMo merged commit 376aba5 into PaddlePaddle:develop Mar 6, 2024
30 checks passed
@xingmingyyj xingmingyyj deleted the add_opcallstack branch March 6, 2024 06:50
@SigureMo SigureMo mentioned this pull request Mar 6, 2024
Merged
@xingmingyyj xingmingyyj mentioned this pull request Mar 7, 2024
Closed
28 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Aurelius84 Aurelius84 Aurelius84 left review comments

@SigureMo SigureMo SigureMo approved these changes

@0x45f 0x45f 0x45f left review comments

@kangguangli kangguangli kangguangli left review comments

Assignees

@SigureMo SigureMo

Labels
contributor External developers
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@xingmingyyj @SigureMo @Aurelius84 @kangguangli @0x45f