Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ShapeOrDataDimExpr simplify unwork #62376

Merged
merged 10 commits into from
Mar 7, 2024
Merged

Conversation

JiaWenxuan
Copy link
Contributor

@JiaWenxuan JiaWenxuan commented Mar 4, 2024

PR types

Bug fixes

PR changes

Others

Description

pcard-76996
This pr amend the SubstituteDimExprBasedOnConstraintsPass and SimplifyDimExprPass to handle the make it work.
In detail:

  • move these two pass below the last symbolic inferring
  • use pointer to change shape_analysis itself instead of the copy one
  • added support for GroupOp or other op which include other ops with recursive proccess

Copy link

paddle-bot bot commented Mar 4, 2024

你的PR提交成功,感谢你对开源项目的贡献!
请关注后续CI自动化测试结果,详情请参考Paddle-CI手册
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

Copy link

paddle-bot bot commented Mar 4, 2024

❌ The PR is not created using PR's template. You can refer to this Demo.
Please use PR's template, it helps save our maintainers' time so that more developers get helped.

@JiaWenxuan JiaWenxuan changed the title Fix SubstituteDimExprBasedOnConstraints Fix ShapeOrDataDimExpr simplify problem Mar 6, 2024
@JiaWenxuan JiaWenxuan changed the title Fix ShapeOrDataDimExpr simplify problem Fix ShapeOrDataDimExpr simplify issue Mar 6, 2024
@JiaWenxuan JiaWenxuan changed the title Fix ShapeOrDataDimExpr simplify issue Fix ShapeOrDataDimExpr simplify unwork Mar 6, 2024
Copy link
Contributor

@jiahy0825 jiahy0825 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zyfncg zyfncg merged commit 7129945 into PaddlePaddle:develop Mar 7, 2024
30 checks passed
co63oc pushed a commit to co63oc/Paddle that referenced this pull request Mar 8, 2024
* update test case

* fix

* fix concat op infer symbolic

* fix some bugs

* fix some bugs

* fix some bugs

* fix some bugs

* fix some bugs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants