[XPU] AdamW: fp16 for moment1/moment2 #62688
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
你的PR提交成功，感谢你对开源项目的贡献! |
|
Sorry to inform you that 125b6a1's CIs have passed for more than 7 days. To prevent PR conflicts, you need to re-run all CIs manually. |
HarperCy
reviewed
Mar 27, 2024
| moment1_output_for_xdnn, | ||
| buffer_for_findmax, | ||
| moment1_out->numel()); | ||
| float moment1_scale_value = 65504.0f / moment1_max / 2.0f; |
There was a problem hiding this comment.
参考per tensor scale设计。内部文档就不往外面贴了。
HarperCy
approved these changes
Mar 27, 2024
houj04
changed the title
QingshuChen
approved these changes
Mar 28, 2024
co63oc
pushed a commit
to co63oc/Paddle
that referenced
this pull request
Mar 29, 2024
* [XPU] AdamW: fp16 for moment1/moment2 on KL3 * fix function name typo.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
New features
PR changes
OPs
Description
类似于 #57077 ，增加对“用fp16来存
moment1和moment2”的支持。使用方式和之前一样：目前仅在XPU下生效，通过
export xpu_adamw_moment_dtype="fp16"来打开此功能。