Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AutoParallel] extract split matmul_grad_op to pass_utils #62737

Merged
merged 6 commits into from
Mar 18, 2024

Conversation

AndSonder
Copy link
Contributor

PR types

Others

PR changes

Others

Description

将 allreduce_matmul_grad_overlapping 中拆分 matmul_grad_op 的操作提取到 pass_utils 当中

相关 Issue:

Copy link

paddle-bot bot commented Mar 14, 2024

你的PR提交成功,感谢你对开源项目的贡献!
请关注后续CI自动化测试结果,详情请参考Paddle-CI手册
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@paddle-bot paddle-bot bot added the contributor External developers label Mar 14, 2024
return out


def _split_matmul_grad_to_matmul(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

向其它模块暴露的接口,不加_前缀



def _split_matmul_grad_to_matmul(
block, matmul_grad_id, op_namescope="/", dist_context=None
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

什么时候会出现dist_context=None的情况呢?

@AndSonder AndSonder requested a review from From00 March 16, 2024 09:15
Copy link
Contributor

@From00 From00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@From00 From00 merged commit 2121ac7 into PaddlePaddle:develop Mar 18, 2024
30 checks passed
@AndSonder AndSonder deleted the split_matmul_grad_v2 branch April 23, 2024 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contributor External developers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants