Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Support Inceemental Compile On Windows] Support Auto Trigger Cmake #62994

Merged

Conversation

xuxinyi389
Copy link
Contributor

@xuxinyi389 xuxinyi389 commented Mar 25, 2024

PR types

Function optimization

PR changes

Others

Description

Pcard-73263
解决当前Windows平台的cmake自动触发问题。5年前的 #15654 设置 CMAKE_SUPPRESS_REGENERATION 为 ON,从而避免MSbuild构建过程中的重复检查、编译warnnings和额外生成目标的问题。但后续该标志也用于控制是否生成一特殊目标,该目标用于检测是否需要重新生成本地构建文件,因此PR15654导致windows平台的构建文件中RERUN_CMAKE规则永远不会被自动触发。此外设置用户环境变量CMAKE_GENRERATOR=Ninja,解决ninja作为生成器时,自动触发cmake过程中的cmake Loop问题。

Copy link

paddle-bot bot commented Mar 25, 2024

你的PR提交成功,感谢你对开源项目的贡献!
请关注后续CI自动化测试结果,详情请参考Paddle-CI手册
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

Copy link
Contributor

@zhwesky2010 zhwesky2010 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这个再多验证一下是不是这个结论

@zhwesky2010 zhwesky2010 merged commit 365efb4 into PaddlePaddle:develop Mar 26, 2024
29 of 30 checks passed
co63oc pushed a commit to co63oc/Paddle that referenced this pull request Mar 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants