Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

【Hackathon 6th Fundable Projects 3 No.393】Remove fluid operator var_conv_2d #63243

Merged
merged 1 commit into from
Apr 18, 2024

Conversation

co63oc
Copy link
Contributor

@co63oc co63oc commented Apr 5, 2024

PR Category

Others

PR Types

Others

Description

Remove fluid operator var_conv_2d

Copy link

paddle-bot bot commented Apr 5, 2024

你的PR提交成功,感谢你对开源项目的贡献!
请关注后续CI自动化测试结果,详情请参考Paddle-CI手册
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@paddle-bot paddle-bot bot added the contributor External developers label Apr 5, 2024
wanghuancoder
wanghuancoder previously approved these changes Apr 8, 2024
Copy link
Contributor

@wanghuancoder wanghuancoder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这种情况,Python端没有API。按理说是可以删除的。但有可能公司内部业务方通过强行调用的方式使用。应该如果存在让他们改成自定义算子的调用方式。
这个应该在待确认的算子清单中,标记为需与业务方确认。
但我认为可以先合入。如果有人找上来了,就说明还有人用。没人找上来,说明没人用了。
结论是先合入。但需要在算子清单中记录这个算子的情况。

@co63oc co63oc changed the title Remove fluid operator var_conv_2d 【Hackathon 6th Fundable Projects No.3】Remove fluid operator var_conv_2d Apr 8, 2024
@co63oc co63oc changed the title 【Hackathon 6th Fundable Projects No.3】Remove fluid operator var_conv_2d 【Hackathon 6th Fundable Projects 3 No.393】Remove fluid operator var_conv_2d Apr 8, 2024
@co63oc
Copy link
Contributor Author

co63oc commented Apr 15, 2024

合入 #63482

@co63oc co63oc closed this Apr 15, 2024
@co63oc co63oc reopened this Apr 16, 2024
Copy link
Contributor

@wanghuancoder wanghuancoder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@luotao1 luotao1 merged commit 8298b96 into PaddlePaddle:develop Apr 18, 2024
29 checks passed
@co63oc co63oc deleted the fix_var_conv branch May 29, 2024 12:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants