Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix cudasynchronize of fft_c2r_compute #63249

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

YibinLiu666
Copy link
Contributor

@YibinLiu666 YibinLiu666 commented Apr 5, 2024

PR Category

Performance Optimization

PR Types

Performance

Description

修复fft_c2r_compute在计算过程中长时间进行cudasynchronize 的问题,使用trust库会导致这个算子在计算时长时间的同步
修复前:
20BE5FD8B1F7F76F94707EE4FC56EA80
修复后:
image

Copy link

paddle-bot bot commented Apr 5, 2024

你的PR提交成功,感谢你对开源项目的贡献!
请关注后续CI自动化测试结果,详情请参考Paddle-CI手册
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@paddle-bot paddle-bot bot added the contributor External developers label Apr 5, 2024
Copy link
Contributor

@HydrogenSulfate HydrogenSulfate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM,可以在描述中加一下nsigh的两个对比图,然后说一下为什么不用thrust库而是手动copy,这样能直观说明问题

Copy link

paddle-ci-bot bot commented Apr 13, 2024

Sorry to inform you that 3f3fc88's CIs have passed for more than 7 days. To prevent PR conflicts, you need to re-run all CIs manually.

Copy link

paddle-ci-bot bot commented Apr 25, 2024

Sorry to inform you that 36d44ea's CIs have passed for more than 7 days. To prevent PR conflicts, you need to re-run all CIs manually.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contributor External developers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants