Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

【Hackathon 6th No.24 】 为 paddle.nn.LSTM/RNNBase 功能增强 -part #63284

Merged
merged 14 commits into from
Apr 19, 2024
Merged

【Hackathon 6th No.24 】 为 paddle.nn.LSTM/RNNBase 功能增强 -part #63284

merged 14 commits into from
Apr 19, 2024

Conversation

Asthestarsfalll
Copy link
Contributor

PR Category

Others

PR Types

Others

Description

为 paddle.nn.LSTM/RNNBase 功能增强:

  1. LSTM支持proj_size参数
  2. RNNBase mode参数支持 RNN_TANH 和 RNN_RELU

@paddle-bot Paddle-bot
Copy link

paddle-bot bot commented Apr 7, 2024

你的PR提交成功，感谢你对开源项目的贡献!
请关注后续CI自动化测试结果，详情请参考Paddle-CI手册。
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@paddle-bot paddle-bot bot added the contributor External developers label Apr 7, 2024
@Asthestarsfalll Asthestarsfalll changed the title NO.24 为 paddle.nn.LSTM/RNNBase 功能增强 【Hackathon 6th No.24 】 为 paddle.nn.LSTM/RNNBase 功能增强 Apr 7, 2024
@luotao1 luotao1 mentioned this pull request Apr 8, 2024
Closed
zhwesky2010
zhwesky2010 reviewed Apr 10, 2024
View reviewed changes
python/paddle/nn/layer/rnn.py Outdated Show resolved Hide resolved
python/paddle/nn/layer/rnn.py Outdated Show resolved Hide resolved
python/paddle/nn/layer/rnn.py Outdated Show resolved Hide resolved
python/paddle/nn/layer/rnn.py Outdated Show resolved Hide resolved
python/paddle/nn/layer/rnn.py Outdated Show resolved Hide resolved
python/paddle/nn/layer/rnn.py Outdated Show resolved Hide resolved
zhwesky2010
zhwesky2010 reviewed Apr 11, 2024
View reviewed changes
python/paddle/nn/layer/rnn.py Show resolved Hide resolved
python/paddle/nn/layer/rnn.py Outdated Show resolved Hide resolved
python/paddle/nn/layer/rnn.py Outdated Show resolved Hide resolved
python/paddle/nn/layer/rnn.py Show resolved Hide resolved
python/paddle/nn/layer/rnn.py Outdated Show resolved Hide resolved
zhwesky2010
zhwesky2010 reviewed Apr 11, 2024
View reviewed changes
python/paddle/nn/layer/rnn.py Outdated Show resolved Hide resolved
python/paddle/nn/layer/rnn.py Outdated Show resolved Hide resolved
zhwesky2010
zhwesky2010 previously approved these changes Apr 12, 2024
View reviewed changes
Copy link
Contributor

@zhwesky2010 zhwesky2010 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zhwesky2010
Copy link
Contributor

@Asthestarsfalll 注意修改对应的 API中文文档、API映射文档

@luotao1
Copy link
Contributor

luotao1 commented Apr 12, 2024 

2024-04-11 22:55:19 ERROR:  /docs/en/develop/api/paddle/nn/LSTMCell_en.html line:  195 has  System Message: ERROR
2024-04-11 22:55:19 error files:  {'/paddle/nn/layer/rnn.py - paddle/nn/LSTMCell_en.html'}
2024-04-11 22:55:19 ERROR: these docs exsits System Message: WARNING/ERROR, please check and fix them

zhwesky2010
zhwesky2010 previously approved these changes Apr 15, 2024
View reviewed changes
@Asthestarsfalll
Copy link
Contributor Author

PR-CI-Paddle-Doc-Preview 没有更详细的提示了

@zhwesky2010
Copy link
Contributor

@sunzhongkai588 帮忙看一下PR-CI-Paddle-Doc-Preview的失败问题

@zhwesky2010 zhwesky2010 mentioned this pull request Apr 16, 2024
Merged
sunzhongkai588
sunzhongkai588 reviewed Apr 16, 2024
View reviewed changes
python/paddle/nn/layer/rnn.py Outdated Show resolved Hide resolved
python/paddle/nn/layer/rnn.py Outdated Show resolved Hide resolved
python/paddle/nn/layer/rnn.py Outdated Show resolved Hide resolved
python/paddle/nn/layer/rnn.py Outdated Show resolved Hide resolved
@Asthestarsfalll
Copy link
Contributor Author

@zhwesky2010 @sunzhongkai588 PR-CI-Paddle-Doc-Preview 已通过，劳烦再看一下～

zhwesky2010
zhwesky2010 previously approved these changes Apr 18, 2024
View reviewed changes
Copy link
Contributor

@zhwesky2010 zhwesky2010 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

sunzhongkai588
sunzhongkai588 previously approved these changes Apr 18, 2024
View reviewed changes
Copy link
Contributor

@sunzhongkai588 sunzhongkai588 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@luotao1
Copy link
Contributor

luotao1 commented Apr 18, 2024

@Asthestarsfalll 请解决下冲突

@luotao1 luotao1 merged commit 67d3fd0 into PaddlePaddle:develop Apr 19, 2024
30 checks passed
@luotao1 luotao1 changed the title 【Hackathon 6th No.24 】 为 paddle.nn.LSTM/RNNBase 功能增强 【Hackathon 6th No.24 】 为 paddle.nn.LSTM/RNNBase 功能增强 -part Apr 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@luotao1 luotao1 luotao1 approved these changes

@sunzhongkai588 sunzhongkai588 sunzhongkai588 left review comments

@zhwesky2010 zhwesky2010 zhwesky2010 left review comments

Assignees

@luotao1 luotao1

@zhwesky2010 zhwesky2010

Labels
contributor External developers PaddlePaddle Hackathon
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Asthestarsfalll @zhwesky2010 @luotao1 @sunzhongkai588