【pir_save_load】add null type saveload and modify save_inference_model api #63438
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
你的PR提交成功，感谢你对开源项目的贡献! |
| @@ -578,7 +674,12 @@ def save_inference_model( | |||
| except OSError as e: | |||
| if e.errno != errno.EEXIST: | |||
| raise | |||
| model_path = path_prefix + ".pdmodel" | |||
|
|
|||
| if in_pir_mode(): | |||
There was a problem hiding this comment.
这样写的话函数中引入了太多in_pir_mode的判断，显得有点乱，是否考虑直接新开一个pir的完整函数分支，在主函数中引入。
changeyoung98
previously approved these changes
Apr 15, 2024
changeyoung98
approved these changes
Apr 15, 2024
Asthestarsfalll
pushed a commit
to Asthestarsfalll/Paddle
that referenced
this pull request
Apr 17, 2024
… api (PaddlePaddle#63438) * add nulltype saveload * add load test * add save * modify * modify load_inference_model * modify loadinference
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Category
others
PR Types
Improvements
Description
pcard-67164
TODO：
predictor 相关的内容需要调研，如何和pir 的saveload对接