【Hackathon 6th No. 7】Add sinc / sinc_ API to Paddle -part #63521

NKNaN · 2024-04-15T03:51:48Z

PR Category

User Experience

PR Types

New features

Description

Add sinc / sinc_ API to Paddle

paddle-bot · 2024-04-15T03:51:53Z

你的PR提交成功，感谢你对开源项目的贡献!
请关注后续CI自动化测试结果，详情请参考Paddle-CI手册。
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

zxcd · 2024-04-17T09:42:39Z

python/paddle/tensor/math.py

+    Returns:
+        out (Tensor): The Tensor of elementwise computed normalized sinc result.
+    """
+    if not isinstance(x, (paddle.Tensor, Variable, paddle.pir.Value)):


propose adding dtype judgment, also adding in test_sinc.py.

zxcd · 2024-04-18T08:55:05Z

python/paddle/tensor/math.py

+    if not isinstance(x, (paddle.Tensor, Variable, paddle.pir.Value)):
+        raise TypeError(f"x must be tensor type, but got {type(x)}")
+
+    if x.dtype not in [


maybe you can use "check_variable_and_dtype", this will make your code look more concise.

NKNaN · 2024-04-22T02:43:45Z

The CI-Coverage check for python code included the last two line of signbit API accidentally.

zxcd · 2024-04-25T02:47:34Z

python/paddle/__init__.py

@@ -487,6 +487,8 @@
    signbit,
    sin,
    sin_,
+    sinc,


also add it in the list of all

zxcd · 2024-04-25T03:50:20Z

test/legacy_test/test_sinc.py

+                res = paddle.sinc(x)
+                static_result = exe.run(feed={'x': x_data}, fetch_list=[res])[0]
+
+    def test_inplace(self):


the type error of inplace API also should be test.

zxcd · 2024-04-25T06:24:45Z

python/paddle/__init__.py

@@ -803,7 +805,8 @@
    'standard_gamma',
    'sinh',
    'sinh_',
-    'round',
+    'sinc',
+    'sinc_' 'round',


attention code style here.

oops..
fixed

zxcd

LGTM

jeff41404 · 2024-04-28T13:08:44Z

python/paddle/tensor/math.py

+    check_variable_and_dtype(
+        x,
+        "x",
+        [


should we support bfloat16?

yes.
bfloat16 added

jeff41404 · 2024-04-28T13:10:42Z

python/paddle/tensor/math.py

+        "sinc",
+    )
+
+    tmp = paddle.where(x != 0, x, paddle.full_like(x, 1.0e-20))


why use 1.0e-20, if data type of x is float16, will there be underflow?

1.0e-20 is used in numpy.sinc, but there is underflow problem when data type is float16.
Fixed the problem using paddle.isnan before returning the final value.

Can we support backward gradient calculation, especially when x=0?

shall we add test case for calculating gradient

shall we add test case for calculating gradient

I will add it

Can we support backward gradient calculation, especially when x=0?

when x=0，the gradient should be 0:

$$( \frac{\sin(\pi x)}{\pi x} )^{\prime} = \pi \frac{\pi x \cos(\pi x) - \sin(\pi x)}{\pi^2 x^2}$$

by LHopital's rule,

$$ \lim_{x \rightarrow 0} \frac{\pi x \cos(\pi x) - \sin(\pi x)}{\pi^2 x^2} = \lim_{x \rightarrow 0} \frac{ [\pi \cos(\pi x) - \pi^2 x \sin(\pi x) ] - \pi \cos(\pi x)}{2 \pi^2 x} = \lim_{x \rightarrow 0} -\frac{\sin(\pi x)}{2} = 0$$

The torch example:

x = torch.rand(2,3) x[0,0] = 0.0 x.requires_grad = True s = torch.sinc(x).sum() s.backward() x.grad # tensor([[ 0.0000, -1.2824, -1.0302], # [-1.3687, -1.0435, -1.1842]])

The current implementation using paddle.where can return gradient value 0 if x = 0

jeff41404 · 2024-04-28T13:11:07Z

python/paddle/tensor/math.py

+    check_variable_and_dtype(
+        x,
+        "x",
+        [


should we support bfloat16?

yes.
bfloat16 added

jeff41404 · 2024-04-28T13:11:50Z

python/paddle/tensor/math.py

+        "sinc_",
+    )
+
+    paddle.where_(x != 0, x, paddle.full_like(x, 1.0e-20))


same issue as above

Fixed the problem using paddle.isnan before returning the final value.

luotao1 · 2024-05-13T09:49:17Z

@NKNaN 看下这里的覆盖率，如果本地单测有覆盖到，请截图贴上。

NKNaN · 2024-05-13T09:56:42Z

@NKNaN 看下这里的覆盖率，如果本地单测有覆盖到，请截图贴上。

这个是 isreal 的内容，不知道为啥这三行也会算到 coverage 检测里面

luotao1 · 2024-05-14T02:38:15Z

这个是 isreal 的内容，不知道为啥这三行也会算到 coverage 检测里面

收到，已经豁免了

jeff41404

LGTM

sunzhongkai588

LGTM

paddle-bot bot added the contributor External developers label Apr 15, 2024

luotao1 added the PaddlePaddle Hackathon label Apr 15, 2024

luotao1 assigned luotao1 and zxcd Apr 15, 2024

NKNaN force-pushed the hack7 branch from f451226 to 0355e6c Compare April 15, 2024 07:44

NKNaN changed the title ~~【Hackthon 6th No. 7】Add sinc / sinc_ API to Paddle~~ 【Hackathon 6th No. 7】Add sinc / sinc_ API to Paddle Apr 15, 2024

luotao1 mentioned this pull request Apr 15, 2024

【Hackathon 6th】开源贡献个人挑战赛 #62905

Closed

zxcd reviewed Apr 18, 2024

View reviewed changes

luotao1 added the API label Apr 24, 2024

zxcd reviewed Apr 25, 2024

View reviewed changes

NKNaN added 12 commits April 25, 2024 13:58

add sinc

3732fd1

fix float16

95313c9

remove cpu fp16 test

4aa79ea

fix tolerance

1cf06bc

update test

c31ad2d

fix timeout

538a9a0

fix fp16 test

70d5d94

fix fp16 test

9a92613

fix fp16 test

43f293c

add dtype check

7183a04

update check dtype

918be06

update test

d120fb8

NKNaN force-pushed the hack7 branch from 62bb892 to d120fb8 Compare April 25, 2024 05:58

zxcd reviewed Apr 25, 2024

View reviewed changes

fix init

f048785

zxcd approved these changes Apr 28, 2024

View reviewed changes

jeff41404 reviewed Apr 28, 2024

View reviewed changes

NKNaN and others added 9 commits April 29, 2024 11:14

add bfloat16 test and fix underflow problem

98d201d

rerun ci

8c8828a

fix test

250225b

fix test

3444e51

Merge branch 'develop' into hack7

0c4affe

fix bf16

f8a78b7

Merge branch 'hack7' of https://github.com/NKNaN/Paddle into hack7

4a92c2a

update test

e61a8af

update test

b9b4cf8

NKNaN mentioned this pull request May 5, 2024

【Hackathon 6th No. 7】Add sinc / sinc_ API to Paddle PaddlePaddle/docs#6634

Merged

NKNaN added 3 commits May 6, 2024 10:24

update test

fd0cd1b

rerun ci

85d201f

fix bf16 test

6a841c1

PaddlePaddle locked and limited conversation to collaborators May 7, 2024

PaddlePaddle unlocked this conversation May 7, 2024

NKNaN added 3 commits May 8, 2024 14:46

rerun ci

8964123

add gradient test

6214fde

add gradient test

af346c1

jeff41404 approved these changes May 14, 2024

View reviewed changes

sunzhongkai588 approved these changes May 15, 2024

View reviewed changes

luotao1 changed the title ~~【Hackathon 6th No. 7】Add sinc / sinc_ API to Paddle~~ 【Hackathon 6th No. 7】Add sinc / sinc_ API to Paddle -part May 15, 2024

luotao1 merged commit 5efe635 into PaddlePaddle:develop May 16, 2024
31 checks passed

NKNaN mentioned this pull request Jun 11, 2024

WAVE SUMMIT+2024上半年飞桨开源之星评选-信息征集 PaddlePaddle/community#892

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

【Hackathon 6th No. 7】Add sinc / sinc_ API to Paddle -part #63521

【Hackathon 6th No. 7】Add sinc / sinc_ API to Paddle -part #63521

NKNaN commented Apr 15, 2024

paddle-bot bot commented Apr 15, 2024

zxcd Apr 17, 2024

NKNaN Apr 18, 2024

zxcd Apr 18, 2024

NKNaN Apr 18, 2024

NKNaN commented Apr 22, 2024

zxcd Apr 25, 2024

NKNaN Apr 25, 2024

zxcd Apr 25, 2024

NKNaN Apr 25, 2024

zxcd Apr 25, 2024

NKNaN Apr 25, 2024

zxcd left a comment

jeff41404 Apr 28, 2024

NKNaN Apr 29, 2024

jeff41404 Apr 28, 2024

NKNaN Apr 29, 2024

jeff41404 May 9, 2024 •

edited

Loading

jeff41404 May 9, 2024

NKNaN May 11, 2024

NKNaN May 11, 2024 •

edited

Loading

jeff41404 Apr 28, 2024

NKNaN Apr 29, 2024

jeff41404 Apr 28, 2024

NKNaN Apr 29, 2024

luotao1 commented May 13, 2024

NKNaN commented May 13, 2024

luotao1 commented May 14, 2024

jeff41404 left a comment

sunzhongkai588 left a comment

【Hackathon 6th No. 7】Add sinc / sinc_ API to Paddle -part #63521

【Hackathon 6th No. 7】Add sinc / sinc_ API to Paddle -part #63521

Conversation

NKNaN commented Apr 15, 2024

PR Category

PR Types

Description

paddle-bot bot commented Apr 15, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

NKNaN commented Apr 22, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

zxcd left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jeff41404 May 9, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

NKNaN May 11, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

luotao1 commented May 13, 2024

NKNaN commented May 13, 2024

luotao1 commented May 14, 2024

jeff41404 left a comment

Choose a reason for hiding this comment

sunzhongkai588 left a comment

Choose a reason for hiding this comment

jeff41404 May 9, 2024 •

edited

Loading

NKNaN May 11, 2024 •

edited

Loading