Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix unittest of fused_rope #63538

Merged
merged 4 commits into from
Apr 16, 2024
Merged

Conversation

kircle888
Copy link
Contributor

PR Category

Others

PR Types

Bug fixes

Description

Fix the bug that the unittest of fused_rope doesn't actually check backward result. Then fix the input generation
of rotate_half to ensure the backward result valid.

Copy link

paddle-bot bot commented Apr 15, 2024

你的PR提交成功,感谢你对开源项目的贡献!
请关注后续CI自动化测试结果,详情请参考Paddle-CI手册
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@paddle-bot paddle-bot bot added the contributor External developers label Apr 15, 2024
GuoxiaWang
GuoxiaWang previously approved these changes Apr 15, 2024
Copy link
Contributor

@GuoxiaWang GuoxiaWang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

GuoxiaWang
GuoxiaWang previously approved these changes Apr 15, 2024
Copy link
Contributor

@GuoxiaWang GuoxiaWang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@GuoxiaWang GuoxiaWang merged commit 42371b2 into PaddlePaddle:develop Apr 16, 2024
29 checks passed
Asthestarsfalll pushed a commit to Asthestarsfalll/Paddle that referenced this pull request Apr 17, 2024
* fix test_fused_rotary_position_embedding
* add assertion & add test_errors
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contributor External developers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants