-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[cmake] update pybind11 v2.10.3 to v2.12.0 #63741
Conversation
你的PR提交成功,感谢你对开源项目的贡献! |
cmake/external/pybind11.cmake
Outdated
@@ -17,24 +17,12 @@ include(ExternalProject) | |||
set(PYBIND_PREFIX_DIR ${THIRD_PARTY_PATH}/pybind) | |||
set(PYBIND_SOURCE_DIR ${PYBIND_PREFIX_DIR}/src/extern_pybind) | |||
set(PYBIND_INCLUDE_DIR ${PYBIND_SOURCE_DIR}/include) | |||
set(PYBIND_TAG v2.10.3) | |||
set(SOURCE_DIR ${PADDLE_SOURCE_DIR}/third_party/pybind) | |||
set(SOURCE_INCLUDE_DIR ${SOURCE_DIR}/include) | |||
|
|||
include_directories(${PYBIND_INCLUDE_DIR}) | |||
|
|||
set(PYBIND_PATCH_COMMAND "") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这行和 50 行是不是也可以删掉了?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
PR Category
Others
PR Types
Others
Description
为了解决在 #63694 遇到的不能使用 shared_ptr 的问题,升级的同时也会解决原来CUDA 12的问题(不再需要patch, pybind11 的修复PR#4893)
test_cpp_extension
)