Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PIR save/load] Migrate static.save and static.load into pir #63749

Merged
merged 8 commits into from
Apr 25, 2024
Merged

[PIR save/load] Migrate static.save and static.load into pir #63749

merged 8 commits into from
Apr 25, 2024

Conversation

changeyoung98
Copy link
Contributor

@changeyoung98 changeyoung98 commented Apr 22, 2024 •
edited
Loading

PR Category

Others

PR Types

Others

Description

pcard-67164

  • 适配并开启test_static_save_load中的单测
    • pir下暂未适配need_check_feed，执行器遇到shape 不匹配问题会报错，因此暂时将报错改为warning，需要进一步讨论该问题的处理方式。
    • nn.fc在pir下执行有问题，暂时从测试中删掉，不影响对api的测试效果
    • 修复pybind中对value.persistable的判断逻辑错误，使用list_vars获得param与opt参数，尽可能与旧IR下获取方式保持一致，减少单测适配工作量。
    • pir下需要在原来的获取param的代码中加入对fetch结果的过滤。
    • pybind中新增pir下的CreateVariableIfNotExist

@paddle-bot Paddle-bot
Copy link

paddle-bot bot commented Apr 22, 2024

你的PR提交成功，感谢你对开源项目的贡献!
请关注后续CI自动化测试结果，详情请参考Paddle-CI手册。
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

xiaoguoguo626807
xiaoguoguo626807 previously approved these changes Apr 24, 2024
View reviewed changes
python/paddle/static/pir_io.py Outdated Show resolved Hide resolved
test/deprecated/legacy_test/test_fill_constant_op.py Show resolved Hide resolved
Aurelius84
Aurelius84 previously approved these changes Apr 25, 2024
View reviewed changes
@changeyoung98 changeyoung98 merged commit 2b79950 into PaddlePaddle:develop Apr 25, 2024
28 of 30 checks passed
@changeyoung98 changeyoung98 deleted the czy-param branch April 26, 2024 02:18
runzhech pushed a commit to runzhech/Paddle that referenced this pull request Apr 30, 2024
@changeyoung98 @runzhech
[PIR save/load] Migrate static.save and static.load into pir (PaddleP…
07f8214 
…addle#63749)

* static.save and static.load passed

* refine

* fix pybind stop_gradient

* fix CI bug

* add create_loaded_params

* fix CI bug

* refine
runzhech pushed a commit to runzhech/Paddle that referenced this pull request Apr 30, 2024
@changeyoung98 @runzhech
[PIR save/load] Migrate static.save and static.load into pir (PaddleP…
0eb6811 
…addle#63749)

* static.save and static.load passed

* refine

* fix pybind stop_gradient

* fix CI bug

* add create_loaded_params

* fix CI bug

* refine
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xiaoguoguo626807 xiaoguoguo626807 xiaoguoguo626807 approved these changes

@Aurelius84 Aurelius84 Aurelius84 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@changeyoung98 @Aurelius84 @xiaoguoguo626807