-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CINN/Fusion] horizontal support dynamic shape and enhance fusion ability #63913
[CINN/Fusion] horizontal support dynamic shape and enhance fusion ability #63913
Conversation
… support-horizontal-fusion
你的PR提交成功,感谢你对开源项目的贡献! |
paddle/cinn/hlir/dialect/operator/transforms/lowering_pass/broadcast_with_cf.cc
Outdated
Show resolved
Hide resolved
return oss.str(); | ||
} | ||
|
||
pir::ShapeConstraintIRAnalysis& shape_analysis() const { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这里函数名大写?这个类是一个struct,且shape_analysis_是一个weak_ptr,是不是把前面成员声明为private好一些,避免直接访问来用。或者改为class
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
收到,下一个PR修改~
Sorry to inform you that 5b48ee7's CIs have passed for more than 7 days. To prevent PR conflicts, you need to re-run all CIs manually. |
@@ -152,7 +152,7 @@ void ApplyDivideGroupOpToFusionOpPass( | |||
std::shared_ptr<pir::PassManager> pass_manager = CreatePassManager(); | |||
if (FLAGS_group_schedule_tiling_first) { | |||
pass_manager->AddPass(cinn::dialect::ir::CreateCinnGroupClusterPass()); | |||
pass_manager->AddPass(cinn::dialect::ir::CreateAddStoreInFusionOpPass()); | |||
// pass_manager->AddPass(cinn::dialect::ir::CreateAddStoreInFusionOpPass()); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
delete this
可以单独提一个pr处理
…lity (PaddlePaddle#63913) * [CINN] Support horizontal fusion * Change data type * Support horizontal fusion * Fix compile error * add topo sort in backend fusion * horizontal support dynamic shape and enhance fusion ability * fix * xx * fix some bugs * fix * xxxx * fix * horizontal operator fusion enhance * fix * fix * fix * fix * fix by code review * fix --------- Co-authored-by: jiahongyu <jiahongyu@baidu.com>
…lity (PaddlePaddle#63913) * [CINN] Support horizontal fusion * Change data type * Support horizontal fusion * Fix compile error * add topo sort in backend fusion * horizontal support dynamic shape and enhance fusion ability * fix * xx * fix some bugs * fix * xxxx * fix * horizontal operator fusion enhance * fix * fix * fix * fix * fix by code review * fix --------- Co-authored-by: jiahongyu <jiahongyu@baidu.com>
PR Category
CINN
PR Types
Improvements
Description
horizontal support dynamic shape and enhance fusion ability
Pcard-76996