Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CINN/Fusion] horizontal support dynamic shape and enhance fusion ability #63913

Merged
merged 26 commits into from
May 17, 2024

Conversation

2742195759
Copy link
Contributor

@2742195759 2742195759 commented Apr 26, 2024

PR Category

CINN

PR Types

Improvements

Description

horizontal support dynamic shape and enhance fusion ability
Pcard-76996

Copy link

paddle-bot bot commented Apr 26, 2024

你的PR提交成功,感谢你对开源项目的贡献!
请关注后续CI自动化测试结果,详情请参考Paddle-CI手册
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

paddle/cinn/hlir/framework/pir/trivial_op_impl.cc Outdated Show resolved Hide resolved
paddle/cinn/hlir/framework/pir/trivial_op_util.cc Outdated Show resolved Hide resolved
paddle/cinn/hlir/framework/pir/trivial_op_util.cc Outdated Show resolved Hide resolved
paddle/cinn/operator_fusion/pattern_fuser.h Show resolved Hide resolved
paddle/cinn/operator_fusion/pattern_fuser.h Outdated Show resolved Hide resolved
paddle/cinn/operator_fusion/utils.h Outdated Show resolved Hide resolved
paddle/cinn/operator_fusion/utils.h Show resolved Hide resolved
paddle/cinn/operator_fusion/utils.h Show resolved Hide resolved
return oss.str();
}

pir::ShapeConstraintIRAnalysis& shape_analysis() const {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这里函数名大写?这个类是一个struct,且shape_analysis_是一个weak_ptr,是不是把前面成员声明为private好一些,避免直接访问来用。或者改为class

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

收到,下一个PR修改~

paddle/cinn/operator_fusion/utils.h Outdated Show resolved Hide resolved
Copy link

paddle-ci-bot bot commented May 8, 2024

Sorry to inform you that 5b48ee7's CIs have passed for more than 7 days. To prevent PR conflicts, you need to re-run all CIs manually.

@phlrain phlrain self-requested a review May 17, 2024 03:47
@@ -152,7 +152,7 @@ void ApplyDivideGroupOpToFusionOpPass(
std::shared_ptr<pir::PassManager> pass_manager = CreatePassManager();
if (FLAGS_group_schedule_tiling_first) {
pass_manager->AddPass(cinn::dialect::ir::CreateCinnGroupClusterPass());
pass_manager->AddPass(cinn::dialect::ir::CreateAddStoreInFusionOpPass());
// pass_manager->AddPass(cinn::dialect::ir::CreateAddStoreInFusionOpPass());
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

delete this
可以单独提一个pr处理

@2742195759 2742195759 merged commit b55bb3a into PaddlePaddle:develop May 17, 2024
31 checks passed
co63oc pushed a commit to co63oc/Paddle that referenced this pull request May 18, 2024
…lity (PaddlePaddle#63913)

* [CINN] Support horizontal fusion

* Change data type

* Support horizontal fusion

* Fix compile error

* add topo sort in backend fusion

* horizontal support dynamic shape and enhance fusion ability

* fix

* xx

* fix some bugs

* fix

* xxxx

* fix

* horizontal operator fusion enhance

* fix

* fix

* fix

* fix

* fix by code review

* fix

---------

Co-authored-by: jiahongyu <jiahongyu@baidu.com>
co63oc pushed a commit to co63oc/Paddle that referenced this pull request May 19, 2024
…lity (PaddlePaddle#63913)

* [CINN] Support horizontal fusion

* Change data type

* Support horizontal fusion

* Fix compile error

* add topo sort in backend fusion

* horizontal support dynamic shape and enhance fusion ability

* fix

* xx

* fix some bugs

* fix

* xxxx

* fix

* horizontal operator fusion enhance

* fix

* fix

* fix

* fix

* fix by code review

* fix

---------

Co-authored-by: jiahongyu <jiahongyu@baidu.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants